Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2649563003: Replace CFX_ByteArray with CFX_ArrayTemplate<uint8_t> (Closed)

Created:
3 years, 11 months ago by Tom Sepez
Modified:
3 years, 11 months ago
Reviewers:
dsinclair, npm
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Replace CFX_ByteArray with CFX_ArrayTemplate<uint8_t> Also replace CFX_Int32Array typedef with CFX_ArrayTemplate<int32_t>. Removing the typedefs makes subsequent conversion to std::vector<> easier on a case-by-case basis. Review-Url: https://codereview.chromium.org/2649563003 Committed: https://pdfium.googlesource.com/pdfium/+/82aa396188ec26f22fe730f4e35b5a54ebffb5dc

Patch Set 1 #

Total comments: 1

Patch Set 2 : re-upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -140 lines) Patch
M core/fxcrt/fx_arabic.h View 3 chunks +14 lines, -14 lines 0 comments Download
M core/fxcrt/fx_arabic.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/fxcrt/fx_basic.h View 1 chunk +0 lines, -5 lines 0 comments Download
M xfa/fde/tto/fde_textout.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fde/xml/cfx_saxreader.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fgas/layout/fgas_rtfbreak.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxbarcode/BC_UtilCodingConvert.h View 1 chunk +4 lines, -2 lines 0 comments Download
M xfa/fxbarcode/BC_UtilCodingConvert.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fxbarcode/BC_Utils.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/fxbarcode/common/BC_CommonBitArray.h View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fxbarcode/common/BC_CommonBitArray.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxbarcode/common/BC_CommonByteArray.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxbarcode/common/BC_CommonByteArray.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxbarcode/common/reedsolomon/BC_ReedSolomon.h View 1 chunk +3 lines, -1 line 0 comments Download
M xfa/fxbarcode/common/reedsolomon/BC_ReedSolomon.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M xfa/fxbarcode/common/reedsolomon/BC_ReedSolomonGF256.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxbarcode/common/reedsolomon/BC_ReedSolomonGF256Poly.h View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/fxbarcode/common/reedsolomon/BC_ReedSolomonGF256Poly.cpp View 6 chunks +11 lines, -11 lines 0 comments Download
M xfa/fxbarcode/datamatrix/BC_DefaultPlacement.h View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fxbarcode/datamatrix/BC_DefaultPlacement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxbarcode/datamatrix/BC_ErrorCorrection.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/fxbarcode/datamatrix/BC_HighLevelEncoder.h View 2 chunks +5 lines, -5 lines 0 comments Download
M xfa/fxbarcode/datamatrix/BC_HighLevelEncoder.cpp View 5 chunks +13 lines, -10 lines 0 comments Download
M xfa/fxbarcode/pdf417/BC_PDF417.h View 1 chunk +4 lines, -3 lines 0 comments Download
M xfa/fxbarcode/pdf417/BC_PDF417.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M xfa/fxbarcode/pdf417/BC_PDF417BarcodeMatrix.h View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/fxbarcode/pdf417/BC_PDF417BarcodeMatrix.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M xfa/fxbarcode/pdf417/BC_PDF417BarcodeRow.h View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/fxbarcode/pdf417/BC_PDF417BarcodeRow.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxbarcode/pdf417/BC_PDF417HighLevelEncoder.h View 2 chunks +6 lines, -5 lines 0 comments Download
M xfa/fxbarcode/pdf417/BC_PDF417HighLevelEncoder.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M xfa/fxbarcode/pdf417/BC_PDF417HighLevelEncoder_unittest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxbarcode/pdf417/BC_PDF417Writer.h View 1 chunk +3 lines, -1 line 0 comments Download
M xfa/fxbarcode/pdf417/BC_PDF417Writer.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/fxbarcode/qrcode/BC_QRCoderEncoder.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxbarcode/qrcode/BC_QRCoderEncoder.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M xfa/fxbarcode/qrcode/BC_QRCoderVersion.h View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fxbarcode/qrcode/BC_QRCoderVersion.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxbarcode/utils.h View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/fxfa/app/cxfa_textlayout.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_ffchoicelist.h View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/fxfa/app/xfa_ffchoicelist.cpp View 8 chunks +10 lines, -9 lines 0 comments Download
M xfa/fxfa/parser/cxfa_resolveprocessor.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cxfa_resolveprocessor.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/cxfa_widgetdata.h View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/cxfa_widgetdata.cpp View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Tom Sepez
Dan or npm, for review.
3 years, 11 months ago (2017-01-20 19:26:43 UTC) #4
npm
lgtm except I can no longer open the 'View' for BC_HighLevelEncoder.cpp https://codereview.chromium.org/2649563003/diff/1/xfa/fxbarcode/datamatrix/BC_HighLevelEncoder.cpp File xfa/fxbarcode/datamatrix/BC_HighLevelEncoder.cpp (right): ...
3 years, 11 months ago (2017-01-20 19:46:48 UTC) #7
Tom Sepez
On 2017/01/20 19:46:48, npm wrote: > lgtm except I can no longer open the 'View' ...
3 years, 11 months ago (2017-01-20 20:03:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649563003/20001
3 years, 11 months ago (2017-01-20 20:36:49 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 20:59:53 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/82aa396188ec26f22fe730f4e35b5a54ebff...

Powered by Google App Engine
This is Rietveld 408576698