Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2649483002: MD Downloads/History: use the Chromium-bundled versions of node and node_modules (Closed)

Created:
3 years, 11 months ago by Dan Beam
Modified:
3 years, 11 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, asanka, calamity, chromium-reviews, dbeam+watch-history_chromium.org, dbeam+watch-downloads_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, pam+watch_chromium.org, tsergeant
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Downloads/History: use the Chromium-bundled versions of node and node_modules R=dpapad@chromium.org BUG=673825 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2649483002 Cr-Commit-Position: refs/heads/master@{#445156} Committed: https://chromium.googlesource.com/chromium/src/+/eecead3bf528702cb98ab2c09885055b26ca8f46

Patch Set 1 : nit #

Patch Set 2 : fix no node on path #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -162 lines) Patch
M chrome/browser/resources/md_downloads/vulcanized.html View 27 chunks +50 lines, -71 lines 0 comments Download
M chrome/browser/resources/md_history/app.vulcanized.html View 18 chunks +43 lines, -69 lines 0 comments Download
M chrome/browser/resources/md_history/lazy_load.vulcanized.html View 6 chunks +3 lines, -9 lines 0 comments Download
M chrome/browser/resources/vulcanize.py View 1 7 chunks +21 lines, -13 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (9 generated)
Dan Beam
3 years, 11 months ago (2017-01-20 08:03:22 UTC) #3
Dan Beam
new node module versions seem to work for me locally let's see what the bots ...
3 years, 11 months ago (2017-01-20 18:26:41 UTC) #4
dpapad
LGTM
3 years, 11 months ago (2017-01-20 18:35:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649483002/40001
3 years, 11 months ago (2017-01-20 20:47:32 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 20:52:52 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/eecead3bf528702cb98ab2c09885...

Powered by Google App Engine
This is Rietveld 408576698