nodejs: Add light python wrappers for running node and friends

nodejs: Add light python wrappers for running node and friends

Adds third_party/node/node.py which automagically selects or runs the
right platform-specific node binary.

Also adds third_party/node/node_modules.py which provides paths to
specific node modules.

BUG=673825
R=dpapad@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2648693002
Cr-Commit-Position: refs/heads/master@{#445088}
Committed: https://chromium.googlesource.com/chromium/src/+/302ecdf84c472a645a508c336401c3fb482570d1

[dpapad, 2017-01-20 03:18:50]

https://codereview.chromium.org/2648693002/diff/1/third_party/node/node.py
File third_party/node/node.py (right):

https://codereview.chromium.org/2648693002/diff/1/third_party/node/node.py#ne...
third_party/node/node.py:27: if __name__ == '__main__':
I don't think this is needed yet, so why add it?

BTW, after removing this, this CL is fairly identical to mine
https://codereview.chromium.org/2638383006. Let's just coordinate tomorrow and
work on one CL collectively instead.

[Dan Beam, 2017-01-20 17:38:12]

https://codereview.chromium.org/2648693002/diff/1/third_party/node/node.py
File third_party/node/node.py (right):

https://codereview.chromium.org/2648693002/diff/1/third_party/node/node.py#ne...
third_party/node/node.py:27: if __name__ == '__main__':
On 2017/01/20 03:18:50, dpapad wrote:
> I don't think this is needed yet, so why add it?
> 
> BTW, after removing this, this CL is fairly identical to mine
> https://codereview.chromium.org/2638383006. Let's just coordinate tomorrow and
> work on one CL collectively instead.

Done.

[Dan Beam, 2017-01-20 17:40:43]

Description was changed from

==========
nodejs: Add light python wrappers for running node and friends

Adds third_party/node/node.py which automagically selects or runs the
right platform-specific node binary.

Also adds third_party/node/node_modules.py which provides paths to
specific node modules.

BUG=673825
R=dpapad@chromium.org
==========

to

==========
nodejs: Add light python wrappers for running node and friends

Adds third_party/node/node.py which automagically selects or runs the
right platform-specific node binary.

Also adds third_party/node/node_modules.py which provides paths to
specific node modules.

BUG=673825
R=dpapad@chromium.org
NOTRY=true
==========

[dpapad, 2017-01-20 17:45:55]

LGTM with quesions.

https://codereview.chromium.org/2648693002/diff/20001/third_party/node/node.py
File third_party/node/node.py (right):

https://codereview.chromium.org/2648693002/diff/20001/third_party/node/node.p...
third_party/node/node.py:9: def GetPlatformPath():
Does this need to be public? Only GetBinaryPath() is used by clients of this
script.

https://codereview.chromium.org/2648693002/diff/20001/third_party/node/node.p...
third_party/node/node.py:15: }[platform.system()])
Don't you need to import this before using it?

[Dan Beam, 2017-01-20 18:02:41]

https://codereview.chromium.org/2648693002/diff/20001/third_party/node/node.py
File third_party/node/node.py (right):

https://codereview.chromium.org/2648693002/diff/20001/third_party/node/node.p...
third_party/node/node.py:9: def GetPlatformPath():
On 2017/01/20 17:45:55, dpapad wrote:
> Does this need to be public? Only GetBinaryPath() is used by clients of this
> script.

Done.

https://codereview.chromium.org/2648693002/diff/20001/third_party/node/node.p...
third_party/node/node.py:15: }[platform.system()])
On 2017/01/20 17:45:55, dpapad wrote:
> Don't you need to import this before using it?

L10

[Dan Beam, 2017-01-20 18:03:39]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2017-01-20 18:03:39]

The patchset sent to the CQ was uploaded after l-g-t-m from dpapad@chromium.org
Link to the patchset: https://codereview.chromium.org/2648693002/#ps40001
(title: ".")

[commit-bot: I haz the power, 2017-01-20 18:03:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 18:08:20]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484935419622030,
"parent_rev": "17305ea8ba2799834b6eda071348c7724e2c68be", "commit_rev":
"302ecdf84c472a645a508c336401c3fb482570d1"}

[commit-bot: I haz the power, 2017-01-20 18:08:57]

Description was changed from

==========
nodejs: Add light python wrappers for running node and friends

Adds third_party/node/node.py which automagically selects or runs the
right platform-specific node binary.

Also adds third_party/node/node_modules.py which provides paths to
specific node modules.

BUG=673825
R=dpapad@chromium.org
NOTRY=true
==========

to

==========
nodejs: Add light python wrappers for running node and friends

Adds third_party/node/node.py which automagically selects or runs the
right platform-specific node binary.

Also adds third_party/node/node_modules.py which provides paths to
specific node modules.

BUG=673825
R=dpapad@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2648693002
Cr-Commit-Position: refs/heads/master@{#445088}
Committed:
https://chromium.googlesource.com/chromium/src/+/302ecdf84c472a645a508c336401...
==========

[commit-bot: I haz the power, 2017-01-20 18:08:58]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/302ecdf84c472a645a508c336401...