Use explicit WebString conversions in chrome/renderer/safe_browsing

Use explicit WebString conversions in chrome/renderer/safe_browsing

As we're deprecating implicit conversions for WebString <-> string16
replace them with explicit methods. (See crbug.com/667131 for more
details)

BUG=667131
Review-Url: https://codereview.chromium.org/2649413002
Cr-Commit-Position: refs/heads/master@{#445930}
Committed: https://chromium.googlesource.com/chromium/src/+/1735825385948a912baf6683ea186813dd88bbad

[kinuko, 2017-01-24 14:16:06]

The CQ bit was checked by kinuko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 14:16:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kinuko, 2017-01-24 14:16:47]

Description was changed from

==========
Use explicit WebString conversions in chrome/renderer/safe_browsing

As we're deprecating implicit conversions for WebString <-> string16
replace them with explicit methods. (See crbug.com/667131 for more
details)

BUG=667131
==========

to

==========
Use explicit WebString conversions in chrome/renderer/safe_browsing

As we're deprecating implicit conversions for WebString <-> string16
replace them with explicit methods. (See crbug.com/667131 for more
details)

BUG=667131
==========

[kinuko, 2017-01-24 14:16:47]

kinuko@chromium.org changed reviewers:
+ shess@chromium.org

[kinuko, 2017-01-24 14:17:03]

Mostly mechanical changes only.  Could you review?

[commit-bot: I haz the power, 2017-01-24 15:26:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 15:26:23]

Dry run: This issue passed the CQ dry run.

[Scott Hess - ex-Googler, 2017-01-24 17:08:46]

Normally, I'd try to evade this review in favor of a newer owner, but having
recently fixed a bug which made me want to remove all implicit conversions in
WebString, I want to participate!

LGTM, with a nit.  If you think my nit is wrong, then still LGTM.

https://codereview.chromium.org/2649413002/diff/1/chrome/renderer/safe_browsi...
File chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc
(right):

https://codereview.chromium.org/2649413002/diff/1/chrome/renderer/safe_browsi...
chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc:103:
full_url = GURL("http://" + base_domain_).Resolve(partial_url.utf16());
AFAICT, GURL::spec_ is UTF-8, though Resolve() can handle either UTF-8 or
UTF-16.  Since there is code above and below which calls partial_url.utf8(),
should this also be utf8()?

[kinuko, 2017-01-25 02:38:06]

Thanks!

https://codereview.chromium.org/2649413002/diff/1/chrome/renderer/safe_browsi...
File chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc
(right):

https://codereview.chromium.org/2649413002/diff/1/chrome/renderer/safe_browsi...
chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc:103:
full_url = GURL("http://" + base_domain_).Resolve(partial_url.utf16());
On 2017/01/24 17:08:46, Scott Hess wrote:
> AFAICT, GURL::spec_ is UTF-8, though Resolve() can handle either UTF-8 or
> UTF-16.  Since there is code above and below which calls partial_url.utf8(),
> should this also be utf8()?

Yeah makes sense, done.  I also changed GURL(partial_url.utf8()) on line 96 with
WebStringToGURL and changed the line 100 a simple assignment.

(Feel free to un-CQ if it doesn't look good or have newer owners make follow-up
changes!)

[kinuko, 2017-01-25 02:38:15]

The CQ bit was checked by kinuko@chromium.org

[kinuko, 2017-01-25 02:38:15]

The patchset sent to the CQ was uploaded after l-g-t-m from shess@chromium.org
Link to the patchset: https://codereview.chromium.org/2649413002/#ps20001
(title: "addressed comments")

[commit-bot: I haz the power, 2017-01-25 02:38:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Scott Hess - ex-Googler, 2017-01-25 03:29:40]

lgtm

[commit-bot: I haz the power, 2017-01-25 03:30:38]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485311895187640,
"parent_rev": "eb6e1f0d57a18e16ffa21254bf954610112f858b", "commit_rev":
"1735825385948a912baf6683ea186813dd88bbad"}

[commit-bot: I haz the power, 2017-01-25 03:31:28]

Description was changed from

==========
Use explicit WebString conversions in chrome/renderer/safe_browsing

As we're deprecating implicit conversions for WebString <-> string16
replace them with explicit methods. (See crbug.com/667131 for more
details)

BUG=667131
==========

to

==========
Use explicit WebString conversions in chrome/renderer/safe_browsing

As we're deprecating implicit conversions for WebString <-> string16
replace them with explicit methods. (See crbug.com/667131 for more
details)

BUG=667131

Review-Url: https://codereview.chromium.org/2649413002
Cr-Commit-Position: refs/heads/master@{#445930}
Committed:
https://chromium.googlesource.com/chromium/src/+/1735825385948a912baf6683ea18...
==========

[commit-bot: I haz the power, 2017-01-25 03:31:29]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1735825385948a912baf6683ea18...