Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5030)

Unified Diff: chrome/renderer/safe_browsing/phishing_classifier.cc

Issue 2649413002: Use explicit WebString conversions in chrome/renderer/safe_browsing (Closed)
Patch Set: addressed comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/safe_browsing/phishing_classifier.cc
diff --git a/chrome/renderer/safe_browsing/phishing_classifier.cc b/chrome/renderer/safe_browsing/phishing_classifier.cc
index d5babf6c1067ad2673f03516561d4749135a30fd..a2246d52d41d8fe1287994d4d362edaa99975553 100644
--- a/chrome/renderer/safe_browsing/phishing_classifier.cc
+++ b/chrome/renderer/safe_browsing/phishing_classifier.cc
@@ -135,9 +135,7 @@ void PhishingClassifier::BeginFeatureExtraction() {
}
blink::WebDataSource* ds = frame->dataSource();
- if (!ds ||
- !base::EqualsASCII(base::StringPiece16(ds->getRequest().httpMethod()),
- "GET")) {
+ if (!ds || ds->getRequest().httpMethod().ascii() != "GET") {
if (ds)
RecordReasonForSkippingClassificationToUMA(SKIP_NONE_GET);
RunFailureCallback();
« no previous file with comments | « no previous file | chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698