Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 2649403003: Fixup coverage build (Closed)

Created:
3 years, 11 months ago by dsinclair
Modified:
3 years, 11 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Fixup coverage build The original coverage CL made the unittests build correclty with coverage but the code in samples/ builds differently. This CL fixes coverage for pdfium_diff and pdfium_test code. Review-Url: https://codereview.chromium.org/2649403003 Committed: https://pdfium.googlesource.com/pdfium/+/6e162b54f708d7957c04d8dffce367fbeaa1a366

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -9 lines) Patch
M BUILD.gn View 3 chunks +10 lines, -9 lines 0 comments Download
M samples/BUILD.gn View 1 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
dsinclair
PTAL.
3 years, 11 months ago (2017-01-24 15:38:31 UTC) #2
Tom Sepez
lgtm https://codereview.chromium.org/2649403003/diff/1/samples/BUILD.gn File samples/BUILD.gn (right): https://codereview.chromium.org/2649403003/diff/1/samples/BUILD.gn#newcode33 samples/BUILD.gn:33: nit: stray blank line
3 years, 11 months ago (2017-01-24 17:10:45 UTC) #3
dsinclair
https://codereview.chromium.org/2649403003/diff/1/samples/BUILD.gn File samples/BUILD.gn (right): https://codereview.chromium.org/2649403003/diff/1/samples/BUILD.gn#newcode33 samples/BUILD.gn:33: On 2017/01/24 17:10:45, Tom Sepez wrote: > nit: stray ...
3 years, 11 months ago (2017-01-24 18:52:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649403003/20001
3 years, 11 months ago (2017-01-24 18:52:15 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 19:18:20 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/6e162b54f708d7957c04d8dffce367fbeaa1...

Powered by Google App Engine
This is Rietveld 408576698