Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: BUILD.gn

Issue 2649403003: Fixup coverage build (Closed)
Patch Set: Review feedback Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | samples/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index b41c1cdb07be453fc2bfa3eff8c01a8ac69d9cb3..c7266d3a1d42c7b7bd552eb64574000e15d726b0 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -7,6 +7,7 @@ import("pdfium.gni")
config("pdfium_common_config") {
cflags = []
+ ldflags = []
include_dirs = [
".",
"third_party/freetype/include",
@@ -37,11 +38,19 @@ config("pdfium_common_config") {
if (pdf_use_win32_gdi) {
defines += [ "PDFIUM_PRINT_TEXT_WITH_GDI" ]
}
+
+ if (use_coverage && is_clang) {
+ cflags += [
+ "--coverage",
+ "-g",
+ "-O0",
+ ]
+ ldflags += [ "--coverage" ]
+ }
}
config("pdfium_core_config") {
cflags = []
- ldflags = []
configs = [ ":pdfium_common_config" ]
defines = [ "V8_DEPRECATION_WARNINGS" ]
if (is_linux) {
@@ -55,14 +64,6 @@ config("pdfium_core_config") {
if (is_win) {
cflags += [ "/wd4267" ]
}
- if (use_coverage && is_clang) {
- cflags += [
- "--coverage",
- "-g",
- "-O0",
- ]
- ldflags += [ "--coverage" ]
- }
}
config("xfa_warnings") {
« no previous file with comments | « no previous file | samples/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698