Revert of WebStateList is an array of web::WebState* wrappers.

Revert of WebStateList is an array of web::WebState* wrappers. (patchset #3 id:40001 of https://codereview.chromium.org/2640093004/ )

Reason for revert:
After offline discussion, WebStateList should probably be a C++ class with a std::vector<WebState*>. Reverting this CL as next step of the refactoring would more or less be a manual revert.

Original issue's description:
> WebStateList is an array of web::WebState* wrappers.
> 
> Introduce a super class of TabModel with the goal of moving all
> the code dealing with Tab management (iteration, selection, ...)
> eventually.
> 
> This is a first step in removing the Tab* class that is mostly
> used as an Objective-C wrapper of web::WebState* with lots of
> helper methods.
> 
> BUG=681867
> 
> Review-Url: https://codereview.chromium.org/2640093004
> Cr-Commit-Position: refs/heads/master@{#445362}
> Committed: https://chromium.googlesource.com/chromium/src/+/3579f53085d00ff7a80eb97bb644a90becddc068

TBR=marq@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=681867
Review-Url: https://codereview.chromium.org/2649403002
Cr-Commit-Position: refs/heads/master@{#446043}
Committed: https://chromium.googlesource.com/chromium/src/+/297553e500df8ab7a94e4b5a89dda921a203e781

[sdefresne, 2017-01-24 13:47:42]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2017-01-24 13:47:43]

Created Revert of WebStateList is an array of web::WebState* wrappers.

[commit-bot: I haz the power, 2017-01-24 13:47:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 13:49:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 13:49:48]

Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[marq (ping after 24h), 2017-01-24 14:34:45]

On 2017/01/24 13:49:48, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
>   ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
>   mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

This failed because I had a CL that depended on this change
(https://codereview.chromium.org/2649403002/); once the revert of that CL lands,
this revert should be OK.

[sdefresne, 2017-01-24 14:54:45]

Dependent CL was reverted, sending back to CQ.

[sdefresne, 2017-01-24 14:54:48]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2017-01-24 14:54:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 14:56:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 14:56:30]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[sdefresne, 2017-01-24 15:07:04]

I had to manually fix some conflicts with other CLs that changed
ios/chrome/browser/tabs/tab_model.mm. Could you please take a look at patchset
#2?

[sdefresne, 2017-01-24 15:09:42]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 15:09:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 15:13:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 15:13:35]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)

[marq (ping after 24h), 2017-01-24 15:42:27]

lgtm

[sdefresne, 2017-01-25 16:11:45]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2017-01-25 16:12:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 17:09:40]

CQ is committing da patch.

Bot data: {"patchset_id": 210001, "attempt_start_ts": 1485360705752370,
"parent_rev": "0a4e2e647f579fc30f46b88acd1a63fafeca9058", "commit_rev":
"297553e500df8ab7a94e4b5a89dda921a203e781"}

[commit-bot: I haz the power, 2017-01-25 17:10:14]

Description was changed from

==========
Revert of WebStateList is an array of web::WebState* wrappers. (patchset #3
id:40001 of https://codereview.chromium.org/2640093004/ )

Reason for revert:
After offline discussion, WebStateList should probably be a C++ class with a
std::vector<WebState*>. Reverting this CL as next step of the refactoring would
more or less be a manual revert.

Original issue's description:
> WebStateList is an array of web::WebState* wrappers.
> 
> Introduce a super class of TabModel with the goal of moving all
> the code dealing with Tab management (iteration, selection, ...)
> eventually.
> 
> This is a first step in removing the Tab* class that is mostly
> used as an Objective-C wrapper of web::WebState* with lots of
> helper methods.
> 
> BUG=681867
> 
> Review-Url: https://codereview.chromium.org/2640093004
> Cr-Commit-Position: refs/heads/master@{#445362}
> Committed:
https://chromium.googlesource.com/chromium/src/+/3579f53085d00ff7a80eb97bb644...

TBR=marq@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=681867
==========

to

==========
Revert of WebStateList is an array of web::WebState* wrappers. (patchset #3
id:40001 of https://codereview.chromium.org/2640093004/ )

Reason for revert:
After offline discussion, WebStateList should probably be a C++ class with a
std::vector<WebState*>. Reverting this CL as next step of the refactoring would
more or less be a manual revert.

Original issue's description:
> WebStateList is an array of web::WebState* wrappers.
> 
> Introduce a super class of TabModel with the goal of moving all
> the code dealing with Tab management (iteration, selection, ...)
> eventually.
> 
> This is a first step in removing the Tab* class that is mostly
> used as an Objective-C wrapper of web::WebState* with lots of
> helper methods.
> 
> BUG=681867
> 
> Review-Url: https://codereview.chromium.org/2640093004
> Cr-Commit-Position: refs/heads/master@{#445362}
> Committed:
https://chromium.googlesource.com/chromium/src/+/3579f53085d00ff7a80eb97bb644...

TBR=marq@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=681867

Review-Url: https://codereview.chromium.org/2649403002
Cr-Commit-Position: refs/heads/master@{#446043}
Committed:
https://chromium.googlesource.com/chromium/src/+/297553e500df8ab7a94e4b5a89dd...
==========

[commit-bot: I haz the power, 2017-01-25 17:10:15]

Committed patchset #2 (id:210001) as
https://chromium.googlesource.com/chromium/src/+/297553e500df8ab7a94e4b5a89dd...