WebStateList is an array of web::WebState* wrappers.

WebStateList is an array of web::WebState* wrappers.

Introduce a super class of TabModel with the goal of moving all
the code dealing with Tab management (iteration, selection, ...)
eventually.

This is a first step in removing the Tab* class that is mostly
used as an Objective-C wrapper of web::WebState* with lots of
helper methods.

BUG=681867
Review-Url: https://codereview.chromium.org/2640093004
Cr-Commit-Position: refs/heads/master@{#445362}
Committed: https://chromium.googlesource.com/chromium/src/+/3579f53085d00ff7a80eb97bb644a90becddc068

[sdefresne, 2017-01-19 12:53:53]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 12:54:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2017-01-19 12:58:41]

sdefresne@chromium.org changed reviewers:
+ marq@chromium.org

[sdefresne, 2017-01-19 12:58:41]

Could you take a first look?

[commit-bot: I haz the power, 2017-01-19 13:20:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 13:20:22]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[marq (ping after 24h), 2017-01-19 13:37:47]

LGTM

Looks great, nits only.

Can web_state_list go into ios/shared?

https://codereview.chromium.org/2640093004/diff/1/ios/chrome/browser/tabs/tab...
File ios/chrome/browser/tabs/tab_model.h (right):

https://codereview.chromium.org/2640093004/diff/1/ios/chrome/browser/tabs/tab...
ios/chrome/browser/tabs/tab_model.h:85: @interface TabModel : WebStateList
WebStateList<Tab*> ?

https://codereview.chromium.org/2640093004/diff/1/ios/chrome/browser/tabs/web...
File ios/chrome/browser/tabs/web_state_list.h (right):

https://codereview.chromium.org/2640093004/diff/1/ios/chrome/browser/tabs/web...
ios/chrome/browser/tabs/web_state_list.h:41: -
(BOOL)containsWebState:(ObjectType)webSate;
webSate -> webState

https://codereview.chromium.org/2640093004/diff/1/ios/chrome/browser/tabs/web...
File ios/chrome/browser/tabs/web_state_list.mm (right):

https://codereview.chromium.org/2640093004/diff/1/ios/chrome/browser/tabs/web...
ios/chrome/browser/tabs/web_state_list.mm:35: return [_list count];
nit: _list.count

https://codereview.chromium.org/2640093004/diff/1/ios/chrome/browser/tabs/web...
ios/chrome/browser/tabs/web_state_list.mm:39: return [_list firstObject];
nit: _list.firstObject

[marq (ping after 24h), 2017-01-19 14:35:11]

https://codereview.chromium.org/2640093004/diff/1/ios/chrome/browser/tabs/web...
File ios/chrome/browser/tabs/web_state_list.mm (right):

https://codereview.chromium.org/2640093004/diff/1/ios/chrome/browser/tabs/web...
ios/chrome/browser/tabs/web_state_list.mm:67: -
(id<WebStateHandle>)webStateAtIndex:(NSUInteger)index {
Do we want to guard against range exceptions by returning nil if index >=
self.count?

[sdefresne, 2017-01-20 13:34:51]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 13:35:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 14:04:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 14:04:27]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[sdefresne, 2017-01-20 14:41:48]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 14:41:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2017-01-20 14:42:09]

Please take another look.

https://codereview.chromium.org/2640093004/diff/1/ios/chrome/browser/tabs/tab...
File ios/chrome/browser/tabs/tab_model.h (right):

https://codereview.chromium.org/2640093004/diff/1/ios/chrome/browser/tabs/tab...
ios/chrome/browser/tabs/tab_model.h:85: @interface TabModel : WebStateList
On 2017/01/19 13:37:46, marq wrote:
> WebStateList<Tab*> ?

Done.

https://codereview.chromium.org/2640093004/diff/1/ios/chrome/browser/tabs/web...
File ios/chrome/browser/tabs/web_state_list.h (right):

https://codereview.chromium.org/2640093004/diff/1/ios/chrome/browser/tabs/web...
ios/chrome/browser/tabs/web_state_list.h:41: -
(BOOL)containsWebState:(ObjectType)webSate;
On 2017/01/19 13:37:46, marq wrote:
> webSate -> webState

Done.

https://codereview.chromium.org/2640093004/diff/1/ios/chrome/browser/tabs/web...
File ios/chrome/browser/tabs/web_state_list.mm (right):

https://codereview.chromium.org/2640093004/diff/1/ios/chrome/browser/tabs/web...
ios/chrome/browser/tabs/web_state_list.mm:35: return [_list count];
On 2017/01/19 13:37:46, marq wrote:
> nit: _list.count

Done.

https://codereview.chromium.org/2640093004/diff/1/ios/chrome/browser/tabs/web...
ios/chrome/browser/tabs/web_state_list.mm:39: return [_list firstObject];
On 2017/01/19 13:37:46, marq wrote:
> nit: _list.firstObject

Done.

https://codereview.chromium.org/2640093004/diff/1/ios/chrome/browser/tabs/web...
ios/chrome/browser/tabs/web_state_list.mm:67: -
(id<WebStateHandle>)webStateAtIndex:(NSUInteger)index {
On 2017/01/19 14:35:11, marq wrote:
> Do we want to guard against range exceptions by returning nil if index >=
> self.count?

I've added a DCHECK, WDYT?

[marq (ping after 24h), 2017-01-20 14:49:17]

Still LGTM, and thanks for moving into /shared.

https://codereview.chromium.org/2640093004/diff/1/ios/chrome/browser/tabs/web...
File ios/chrome/browser/tabs/web_state_list.mm (right):

https://codereview.chromium.org/2640093004/diff/1/ios/chrome/browser/tabs/web...
ios/chrome/browser/tabs/web_state_list.mm:67: -
(id<WebStateHandle>)webStateAtIndex:(NSUInteger)index {
On 2017/01/20 14:42:09, sdefresne wrote:
> On 2017/01/19 14:35:11, marq wrote:
> > Do we want to guard against range exceptions by returning nil if index >=
> > self.count?
> 
> I've added a DCHECK, WDYT?

Doesn't that just trade one exception for another? If you think it's better to
throw for a range exception then that's fine, but I was thinking we could return
nil in that case instead of throwing.

[commit-bot: I haz the power, 2017-01-20 15:34:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 15:34:13]

Dry run: This issue passed the CQ dry run.

[sdefresne, 2017-01-23 10:51:14]

On 2017/01/20 14:49:17, marq wrote:
> Still LGTM, and thanks for moving into /shared.
> 
>
https://codereview.chromium.org/2640093004/diff/1/ios/chrome/browser/tabs/web...
> File ios/chrome/browser/tabs/web_state_list.mm (right):
> 
>
https://codereview.chromium.org/2640093004/diff/1/ios/chrome/browser/tabs/web...
> ios/chrome/browser/tabs/web_state_list.mm:67: -
> (id<WebStateHandle>)webStateAtIndex:(NSUInteger)index {
> On 2017/01/20 14:42:09, sdefresne wrote:
> > On 2017/01/19 14:35:11, marq wrote:
> > > Do we want to guard against range exceptions by returning nil if index >=
> > > self.count?
> > 
> > I've added a DCHECK, WDYT?
> 
> Doesn't that just trade one exception for another? If you think it's better to
> throw for a range exception then that's fine, but I was thinking we could
return
> nil in that case instead of throwing.

TabModel does not check that the index is valid (no DCHECK, no runtime check
either). That's why I was not using one initially. Using an incorrect index is a
programmatic error so I think DCHECK is the correct way to flag it here
according to Chrome style (i.e. don't support invalid code, assert in case of
error).

[sdefresne, 2017-01-23 10:51:22]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2017-01-23 10:51:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 12:15:43]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485168682743410,
"parent_rev": "afdd805e2cb7ee4941a73b08fc37cf9c91f78ea4", "commit_rev":
"3579f53085d00ff7a80eb97bb644a90becddc068"}

[commit-bot: I haz the power, 2017-01-23 12:16:16]

Description was changed from

==========
WebStateList is an array of web::WebState* wrappers.

Introduce a super class of TabModel with the goal of moving all
the code dealing with Tab management (iteration, selection, ...)
eventually.

This is a first step in removing the Tab* class that is mostly
used as an Objective-C wrapper of web::WebState* with lots of
helper methods.

BUG=681867
==========

to

==========
WebStateList is an array of web::WebState* wrappers.

Introduce a super class of TabModel with the goal of moving all
the code dealing with Tab management (iteration, selection, ...)
eventually.

This is a first step in removing the Tab* class that is mostly
used as an Objective-C wrapper of web::WebState* with lots of
helper methods.

BUG=681867

Review-Url: https://codereview.chromium.org/2640093004
Cr-Commit-Position: refs/heads/master@{#445362}
Committed:
https://chromium.googlesource.com/chromium/src/+/3579f53085d00ff7a80eb97bb644...
==========

[commit-bot: I haz the power, 2017-01-23 12:16:17]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/3579f53085d00ff7a80eb97bb644...

[sdefresne, 2017-01-24 13:47:42]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2649403002/ by sdefresne@chromium.org.

The reason for reverting is: After offline discussion, WebStateList should
probably be a C++ class with a std::vector<WebState*>. Reverting this CL as next
step of the refactoring would more or less be a manual revert..