Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 2649373002: Re-land: Update json_schema_compiler to handle the Automation extension API (Closed)

Created:
3 years, 11 months ago by dmazzoni
Modified:
3 years, 11 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, alemate+watch_chromium.org, oshima+watch_chromium.org, aboxhall+watch_chromium.org, jlklein+watch-closure_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, vitalyp+closure_chromium.org, chromium-apps-reviews_chromium.org, dbeam+watch-closure_chromium.org, dmazzoni+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-land: Update json_schema_compiler to handle the Automation extension API Originally landed as r445146: https://codereview.chromium.org/2601333002 Reverted as r445428. Fixed by deferring the initialization of DesktopAutomationHandler to match the previous behavior that was significant when tests are run in debug mode. This allows the automation externs file to be fully autogenerated. Lots of tweaks to ChromeVox were required since we've been working with a hand-tweaked externs file for a while. BUG=683915 TBR=dtseng@chromium.org,rdevlin.cronin@chromium.org,dbeam@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/f1cbfff18b19ff99310ffbfb94ca75462da7a859 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2649373002 Cr-Commit-Position: refs/heads/master@{#446160} Committed: https://chromium.googlesource.com/chromium/src/+/5964242ae4c92988b391db18328b162937f8da3b

Patch Set 1 #

Patch Set 2 : Fix for interative_ui_tests in dbg mode #

Patch Set 3 : Rebase #

Patch Set 4 : Add back AutomationObjectConstructorInstaller to fix tests #

Patch Set 5 : Fix presubmit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1730 lines, -995 lines) Patch
M chrome/browser/resources/chromeos/chromevox/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/chrome_extension_externs.js View 1 chunk +0 lines, -8 lines 0 comments Download
D chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_object_constructor_installer.js View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js View 18 chunks +89 lines, -88 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util.js View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util_test.extjs View 3 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js View 9 chunks +21 lines, -18 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs View 1 2 19 chunks +27 lines, -27 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/command_handler.js View 9 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors.js View 11 chunks +22 lines, -22 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs View 3 chunks +8 lines, -8 lines 0 comments Download
A chrome/browser/resources/chromeos/chromevox/cvox2/background/custom_automation_event.js View 1 chunk +33 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js View 1 2 3 4 17 chunks +65 lines, -48 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/editing.js View 6 chunks +13 lines, -12 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/find_handler.js View 3 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/live_regions.js View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/live_regions_test.extjs View 7 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/media_automation_handler.js View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js View 1 2 13 chunks +37 lines, -32 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/tabs_automation_handler.js View 3 chunks +10 lines, -7 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/tree_walker.js View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/select_to_speak/select_to_speak.js View 3 chunks +9 lines, -9 lines 0 comments Download
M chrome/common/extensions/api/automation.idl View 6 chunks +161 lines, -55 lines 0 comments Download
M chrome/renderer/extensions/automation_internal_custom_bindings.cc View 3 chunks +8 lines, -30 lines 0 comments Download
M chrome/renderer/resources/extensions/automation/automation_node.js View 10 chunks +18 lines, -29 lines 0 comments Download
M chrome/renderer/resources/extensions/automation_custom_bindings.js View 6 chunks +7 lines, -18 lines 0 comments Download
M chrome/test/data/extensions/api_test/active_tab/background.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/automation/tests/desktop/actions.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/automation/tests/desktop/desktop.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/automation/tests/desktop/focus_views.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/automation/tests/desktop/load_tabs.js View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/data/extensions/api_test/automation/tests/generated/generated_trees.js View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/test/data/extensions/api_test/automation/tests/tabs/actions.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/automation/tests/tabs/attributes.js View 1 chunk +9 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/automation/tests/tabs/bounds_for_range.js View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/test/data/extensions/api_test/automation/tests/tabs/close_tab.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/automation/tests/tabs/document_selection.js View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/test/data/extensions/api_test/automation/tests/tabs/events.js View 4 chunks +16 lines, -16 lines 0 comments Download
M chrome/test/data/extensions/api_test/automation/tests/tabs/find.js View 4 chunks +80 lines, -64 lines 0 comments Download
M chrome/test/data/extensions/api_test/automation/tests/tabs/image_data.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/automation/tests/tabs/line_start_offsets.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/automation/tests/tabs/location.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/automation/tests/tabs/location2.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/automation/tests/tabs/sanity_check.js View 2 chunks +4 lines, -5 lines 0 comments Download
M third_party/closure_compiler/externs/automation.js View 4 chunks +870 lines, -396 lines 0 comments Download
M tools/json_schema_compiler/idl_schema.py View 3 chunks +12 lines, -3 lines 0 comments Download
M tools/json_schema_compiler/idl_schema_test.py View 2 chunks +6 lines, -1 line 0 comments Download
M tools/json_schema_compiler/js_externs_generator.py View 8 chunks +41 lines, -8 lines 0 comments Download
M tools/json_schema_compiler/js_externs_generator_test.py View 2 chunks +49 lines, -0 lines 0 comments Download
M tools/json_schema_compiler/js_util.py View 1 chunk +12 lines, -0 lines 0 comments Download
M tools/json_schema_compiler/model.py View 2 chunks +4 lines, -2 lines 0 comments Download
M ui/accessibility/PRESUBMIT.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (14 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649373002/20001
3 years, 11 months ago (2017-01-24 05:06:31 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/140934) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 11 months ago (2017-01-24 05:08:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649373002/40001
3 years, 11 months ago (2017-01-24 17:13:37 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/199071) android_cronet on master.tryserver.chromium.android (JOB_FAILED, ...
3 years, 11 months ago (2017-01-24 17:18:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649373002/40001
3 years, 11 months ago (2017-01-24 20:09:57 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/352412)
3 years, 11 months ago (2017-01-24 21:03:23 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649373002/80001
3 years, 11 months ago (2017-01-25 23:10:02 UTC) #19
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 23:18:28 UTC) #22
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/5964242ae4c92988b391db18328b...

Powered by Google App Engine
This is Rietveld 408576698