chrome/browser/resources/chromeos/chromevox/cvox2/background/tree_walker.js - Issue 2649373002: Re-land: Update json_schema_compiler to handle the Automation extension API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/tree_walker.js

Issue 2649373002: Re-land: Update json_schema_compiler to handle the Automation extension API (Closed)

Patch Set: Fix presubmit Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/cvox2/background/tabs_automation_handler.js ('k') | chrome/browser/resources/chromeos/select_to_speak/select_to_speak.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/tree_walker.js

diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/tree_walker.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/tree_walker.js

index f947a066c4d1a248288fda4c48dcef89f11e5023..268ce13edb8180be10d43907391dd8c2d030836a 100644

--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/tree_walker.js

+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/tree_walker.js

@@ -88,7 +88,7 @@ AutomationTreeWalker = function(node, dir, opt_restrictions) {

* backward.

* @type {chrome.automation.AutomationNode} @private

- this.backwardAncestor_ = node.parent;

+ this.backwardAncestor_ = node.parent || null;

var restrictions = opt_restrictions || {};

this.visitPred_ = function(node) {

@@ -221,8 +221,8 @@ AutomationTreeWalker.prototype = {

}

if (node.parent && this.backwardAncestor_ == node.parent) {

this.phase_ = AutomationTreeWalkerPhase.ANCESTOR;

- this.backwardAncestor_ = node.parent.parent;

+ this.backwardAncestor_ = node.parent.parent || null;

}

- this.node_ = node.parent;

+ this.node_ = node.parent || null;

}

};