Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 2649323012: [ARM] Add Neon saturating add and subtract instructions. (Closed)

Created:
3 years, 10 months ago by bbudge
Modified:
3 years, 10 months ago
Reviewers:
titzer, martyn.capewell
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ARM] Add Neon saturating add and subtract instructions. - Adds vqadd.s/u, vqsub.s/u for all integer lane sizes. - Refactors disassembler and simulator, using switches instead of long if-else chains. LOG=N BUG=v8:4124 Review-Url: https://codereview.chromium.org/2649323012 Cr-Commit-Position: refs/heads/master@{#42865} Committed: https://chromium.googlesource.com/v8/v8/+/b7df78f363da3f14e8ac54b3498a3556d3fba740

Patch Set 1 #

Total comments: 2

Patch Set 2 : Template-ize Add and Sub Saturate operations. #

Total comments: 3

Patch Set 3 : Add static_asserts on Widen, Clamp. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+987 lines, -646 lines) Patch
M src/arm/assembler-arm.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/arm/assembler-arm.cc View 4 chunks +35 lines, -1 line 0 comments Download
M src/arm/disasm-arm.cc View 8 chunks +261 lines, -182 lines 0 comments Download
M src/arm/simulator-arm.cc View 1 2 4 chunks +622 lines, -463 lines 0 comments Download
M test/cctest/test-assembler-arm.cc View 1 4 chunks +53 lines, -0 lines 0 comments Download
M test/cctest/test-disasm-arm.cc View 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 32 (23 generated)
bbudge
3 years, 10 months ago (2017-01-27 02:33:56 UTC) #7
martyn.capewell
https://codereview.chromium.org/2649323012/diff/1/src/arm/simulator-arm.cc File src/arm/simulator-arm.cc (right): https://codereview.chromium.org/2649323012/diff/1/src/arm/simulator-arm.cc#newcode4011 src/arm/simulator-arm.cc:4011: int8_t src1[16], src2[16]; It might be possible to factor ...
3 years, 10 months ago (2017-01-30 13:50:47 UTC) #8
bbudge
https://codereview.chromium.org/2649323012/diff/1/src/arm/simulator-arm.cc File src/arm/simulator-arm.cc (right): https://codereview.chromium.org/2649323012/diff/1/src/arm/simulator-arm.cc#newcode4011 src/arm/simulator-arm.cc:4011: int8_t src1[16], src2[16]; On 2017/01/30 13:50:47, martyn.capewell wrote: > ...
3 years, 10 months ago (2017-01-31 19:58:24 UTC) #13
martyn.capewell
lgtm https://codereview.chromium.org/2649323012/diff/20001/src/arm/simulator-arm.cc File src/arm/simulator-arm.cc (right): https://codereview.chromium.org/2649323012/diff/20001/src/arm/simulator-arm.cc#newcode3995 src/arm/simulator-arm.cc:3995: return static_cast<int64_t>(value); Perhaps assert sizeof(T) < sizeof(value), as ...
3 years, 10 months ago (2017-02-01 11:44:15 UTC) #18
martyn.capewell
https://codereview.chromium.org/2649323012/diff/20001/src/arm/simulator-arm.cc File src/arm/simulator-arm.cc (right): https://codereview.chromium.org/2649323012/diff/20001/src/arm/simulator-arm.cc#newcode3995 src/arm/simulator-arm.cc:3995: return static_cast<int64_t>(value); I mean, sizeof(value) < sizeof(int64_t)
3 years, 10 months ago (2017-02-01 11:45:49 UTC) #19
bbudge
+Ben for OWNERS https://codereview.chromium.org/2649323012/diff/20001/src/arm/simulator-arm.cc File src/arm/simulator-arm.cc (right): https://codereview.chromium.org/2649323012/diff/20001/src/arm/simulator-arm.cc#newcode3995 src/arm/simulator-arm.cc:3995: return static_cast<int64_t>(value); On 2017/02/01 11:45:49, martyn.capewell ...
3 years, 10 months ago (2017-02-01 18:12:20 UTC) #23
titzer
lgtm
3 years, 10 months ago (2017-02-01 18:24:18 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649323012/40001
3 years, 10 months ago (2017-02-01 18:54:52 UTC) #29
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 18:56:37 UTC) #32
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/b7df78f363da3f14e8ac54b3498a3556d3f...

Powered by Google App Engine
This is Rietveld 408576698