Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 2649253003: [Mac] Sinkhole __NSFireDelayedPerform and _CFXNotificationPost in the exception preprocessor. (Closed)

Created:
3 years, 11 months ago by Robert Sesek
Modified:
3 years, 11 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Sinkhole __NSFireDelayedPerform and _CFXNotificationPost in the exception preprocessor. BUG=637270 TEST=unit_tests --gtest_filter=ExceptionProcessorTest.* R=mark@chromium.org Review-Url: https://codereview.chromium.org/2649253003 Cr-Commit-Position: refs/heads/master@{#445748} Committed: https://chromium.googlesource.com/chromium/src/+/7f2f9fa01e93d95339d0773ce5dd527cbc717532

Patch Set 1 #

Patch Set 2 : Notification observers too #

Patch Set 3 : DVLOG #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -0 lines) Patch
M chrome/browser/mac/exception_processor.mm View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/mac/exception_processor_unittest.mm View 1 1 chunk +59 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
Robert Sesek
3 years, 11 months ago (2017-01-23 23:21:10 UTC) #5
Mark Mentovai
LGTM
3 years, 11 months ago (2017-01-24 03:36:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649253003/10003
3 years, 11 months ago (2017-01-24 16:57:42 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 17:20:06 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:10003) as
https://chromium.googlesource.com/chromium/src/+/7f2f9fa01e93d95339d0773ce5dd...

Powered by Google App Engine
This is Rietveld 408576698