Issue 2649213002: Fix regression of webview loadstart events firing for same page navigations.

Issue 2649213002: Fix regression of webview loadstart events firing for same page navigations. (Closed)

Created:
3 years, 11 months ago by jam

Modified:
3 years, 11 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2987

Project:
chromium

Visibility:
Public.

Fix regression of webview loadstart events firing for same page navigations. This regressed in r425073 since DidStartProvisionalLoadForFrame didn't fire for same page navigations while DidStartNavigation does. BUG=680863 Review-Url: https://codereview.chromium.org/2647933002 Cr-Commit-Position: refs/heads/master@{#445150} (cherry picked from commit 840012cf9996d156f6e3286a37ca0c9d5d502edc) Review-Url: https://codereview.chromium.org/2649213002 . Cr-Commit-Position: refs/branch-heads/2987@{#29} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/852d488f12bf3778e57c4d7a50316c6006c4d108

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+53 lines, -0 lines)			Patch
M	extensions/browser/guest_view/web_view/web_view_apitest.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	extensions/browser/guest_view/web_view/web_view_guest.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
A	extensions/test/data/web_view/apitest/guest_same_page_navigation.html	View	1 chunk	+17 lines, -0 lines	0 comments	Download
M	extensions/test/data/web_view/apitest/main.js	View	3 chunks	+25 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

jam

3 years, 11 months ago (2017-01-23 18:44:09 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
852d488f12bf3778e57c4d7a50316c6006c4d108.