Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2647933002: Fix regression of webview loadstart events firing for same page navigations. (Closed)

Created:
3 years, 11 months ago by jam
Modified:
3 years, 11 months ago
Reviewers:
wjmaclean
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix regression of webview loadstart events firing for same page navigations. This regressed in r425073 since DidStartProvisionalLoadForFrame didn't fire for same page navigations while DidStartNavigation does. BUG=680863 Review-Url: https://codereview.chromium.org/2647933002 Cr-Commit-Position: refs/heads/master@{#445150} Committed: https://chromium.googlesource.com/chromium/src/+/840012cf9996d156f6e3286a37ca0c9d5d502edc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -0 lines) Patch
M extensions/browser/guest_view/web_view/web_view_apitest.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_guest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
A extensions/test/data/web_view/apitest/guest_same_page_navigation.html View 1 chunk +17 lines, -0 lines 0 comments Download
M extensions/test/data/web_view/apitest/main.js View 3 chunks +25 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
jam
3 years, 11 months ago (2017-01-20 20:20:13 UTC) #11
wjmaclean
LGTM Thanks!
3 years, 11 months ago (2017-01-20 20:23:52 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2647933002/1
3 years, 11 months ago (2017-01-20 20:29:51 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 20:39:51 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/840012cf9996d156f6e3286a37ca...

Powered by Google App Engine
This is Rietveld 408576698