Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2649133009: Merge "arc: Fix CreateFloatingCloseButton crash" (Closed)

Created:
3 years, 11 months ago by xiyuan
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Merge "arc: Fix CreateFloatingCloseButton crash" > Move UpdatePinnedState into AttachSurface since floating close button > participates in the focus chain of the hosting widget now. To create it, > both |surface_| and the hosting widget needs to be present. > > BUG=682868 > > Review-Url: https://codereview.chromium.org/2646143002 > Cr-Commit-Position: refs/heads/master@{#445754} > (cherry picked from commit 57d39edccd4352d933347b9742010740cef62ce5) Review-Url: https://codereview.chromium.org/2649133009 . Cr-Commit-Position: refs/branch-heads/2987@{#61} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/1b0254b78a3cd0d23233bb02ba0f39d0bd3f99b3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M ui/arc/notification/arc_custom_notification_view.cc View 3 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
xiyuan
3 years, 11 months ago (2017-01-24 18:12:53 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1b0254b78a3cd0d23233bb02ba0f39d0bd3f99b3.

Powered by Google App Engine
This is Rietveld 408576698