Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2649133008: Remove another use of old CreateShadowDrawLooper. (Closed)

Created:
3 years, 11 months ago by Evan Stade
Modified:
3 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, dcheng
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove another use of old CreateShadowDrawLooper. gfx::RenderText::set_shadows is only used by Label and in turn LabelButton. Only two places actually set a non-zero blur value, and both are updated in this patch. BUG=624175 Review-Url: https://codereview.chromium.org/2649133008 Cr-Commit-Position: refs/heads/master@{#445786} Committed: https://chromium.googlesource.com/chromium/src/+/a972d37e1b2a724300e3104f947f8acc5829951b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/ui/views/profiles/new_avatar_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/render_text.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/button_drag_utils.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Evan Stade
3 years, 11 months ago (2017-01-24 18:01:34 UTC) #4
sky
LGTM
3 years, 11 months ago (2017-01-24 19:09:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649133008/1
3 years, 11 months ago (2017-01-24 19:50:56 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 19:58:28 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a972d37e1b2a724300e3104f947f...

Powered by Google App Engine
This is Rietveld 408576698