Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 2649113007: s390: TF Codegen Optimization (Closed)

Created:
3 years, 11 months ago by john.yan
Modified:
3 years, 11 months ago
Reviewers:
JoranSiu, JaideepBajwa
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

s390: TF Codegen Optimization List of items: 1. Avoid zero-extending for subsequent 32-bit operations if current operation does not change upper 32-bit or does zero-extending. 2. Match complex address mode for binary operation where possible (eg. use Add R,MEM). 3. Detect instruction forms in selector. Eg. kAllowRRR, kAllowRM 4. Optimize sequence for Int32MulWithOverflow, Int32Div, etc. 5. Remove Not32/Not64 which is the same as XOR R=bjaideep@ca.ibm.com, joransiu@ca.ibm.com BUG= Review-Url: https://codereview.chromium.org/2649113007 Cr-Commit-Position: refs/heads/master@{#42669} Committed: https://chromium.googlesource.com/v8/v8/+/f7a3ede0820ee6c30ac6e5199536a0c60f69d331

Patch Set 1 #

Patch Set 2 : remove 2 unnecessary unreachables #

Unified diffs Side-by-side diffs Delta from patch set Stats (+890 lines, -295 lines) Patch
M src/compiler/s390/code-generator-s390.cc View 1 19 chunks +263 lines, -90 lines 0 comments Download
M src/compiler/s390/instruction-codes-s390.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/compiler/s390/instruction-scheduler-s390.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/compiler/s390/instruction-selector-s390.cc View 39 chunks +439 lines, -185 lines 0 comments Download
M src/s390/assembler-s390.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/s390/assembler-s390.cc View 2 chunks +13 lines, -1 line 0 comments Download
M src/s390/disasm-s390.cc View 3 chunks +18 lines, -0 lines 0 comments Download
M src/s390/macro-assembler-s390.h View 3 chunks +14 lines, -0 lines 0 comments Download
M src/s390/macro-assembler-s390.cc View 4 chunks +73 lines, -1 line 0 comments Download
M src/s390/simulator-s390.cc View 4 chunks +63 lines, -18 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
john.yan
ptal
3 years, 11 months ago (2017-01-25 18:52:23 UTC) #1
JaideepBajwa
lgtm
3 years, 11 months ago (2017-01-25 20:25:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649113007/20001
3 years, 11 months ago (2017-01-25 23:10:13 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 23:42:20 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/f7a3ede0820ee6c30ac6e5199536a0c60f6...

Powered by Google App Engine
This is Rietveld 408576698