Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(699)

Issue 2649103008: Revert of Add smooth interpolation support for <color> custom properties (Closed)

Created:
3 years, 11 months ago by sof
Modified:
3 years, 11 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, chromium-reviews, dglazkov+blink, Eric Willigers, rjwright, rwlbuis, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add smooth interpolation support for <color> custom properties (patchset #5 id:80001 of https://codereview.chromium.org/2564793002/ ) Reason for revert: Added test is seen failing on the bots, e.g., https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/22494 https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11/builds/15502 Original issue's description: > Add smooth interpolation support for <color> custom properties > > This change enables smooth interpolation for animations on > custom properties registered as <color>. > > This does not add support for CSS Transitions, only CSS > Animations and Web Animations. > This does not add support for currentcolor for CSS Animations, > supporting this may require further redesigns to style resolution. > > BUG=671904 > > Review-Url: https://codereview.chromium.org/2564793002 > Cr-Commit-Position: refs/heads/master@{#445967} > Committed: https://chromium.googlesource.com/chromium/src/+/96bee2c42c8df73523e971850215d29d1c40c15f TBR=sashab@chromium.org,alancutter@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=671904 Review-Url: https://codereview.chromium.org/2649103008 Cr-Commit-Position: refs/heads/master@{#445994} Committed: https://chromium.googlesource.com/chromium/src/+/14ab21ed2e07a78a0b4af6b8a09ff5de06b6d33d

Patch Set 1 #

Messages

Total messages: 6 (3 generated)
sof
Created Revert of Add smooth interpolation support for <color> custom properties
3 years, 11 months ago (2017-01-25 10:46:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649103008/1
3 years, 11 months ago (2017-01-25 10:46:17 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 10:47:25 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/14ab21ed2e07a78a0b4af6b8a09f...

Powered by Google App Engine
This is Rietveld 408576698