Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2649083003: Fix LG Email workaround criteria. (Closed)

Created:
3 years, 11 months ago by aelias_OOO_until_Jul13
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Fix LG Email workaround criteria. 1) We were accidentally checking Build.VERSION.SDK_INT (version of the WebView package) when the intent was to check the targetSdkVersion of the app package itself. This would come to bite us and globally disable the workaround when we upgrade the WebView to O. 2) Decrease the APK version check to 67502100 which is the version of com.lge.email actually shipped on LG V20. The intent is for the workaround to be purely grandfathering existing nonupdatable APKs so there isn't a reason to leave headroom. 3) Take advantage of PackageUtils.getPackageVersion. BUG=651706, 683294 Review-Url: https://codereview.chromium.org/2643943004 Cr-Commit-Position: refs/heads/master@{#445509} (cherry picked from commit 9079de0121eb747464e490e29fd2444dde5f0847) Review-Url: https://codereview.chromium.org/2649083003 . Cr-Commit-Position: refs/branch-heads/2987@{#44} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/0c274309d19ab755d13fc41d03be2c28aa21d71d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -25 lines) Patch
M android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java View 4 chunks +6 lines, -4 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/LGEmailActionModeWorkaround.java View 5 chunks +20 lines, -21 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
aelias_OOO_until_Jul13
3 years, 11 months ago (2017-01-23 23:03:25 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0c274309d19ab755d13fc41d03be2c28aa21d71d.

Powered by Google App Engine
This is Rietveld 408576698