Chromium Code Reviews
DescriptionFix LG Email workaround criteria.
1) We were accidentally checking Build.VERSION.SDK_INT (version of the
WebView package) when the intent was to check the targetSdkVersion of
the app package itself. This would come to bite us and globally disable
the workaround when we upgrade the WebView to O.
2) Decrease the APK version check to 67502100 which is the version of
com.lge.email actually shipped on LG V20. The intent is for the
workaround to be purely grandfathering existing nonupdatable APKs so
there isn't a reason to leave headroom.
3) Take advantage of PackageUtils.getPackageVersion.
BUG=651706, 683294
Review-Url: https://codereview.chromium.org/2643943004
Cr-Commit-Position: refs/heads/master@{#445509}
(cherry picked from commit 9079de0121eb747464e490e29fd2444dde5f0847)
Review-Url: https://codereview.chromium.org/2649083003 .
Cr-Commit-Position: refs/branch-heads/2987@{#44}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Committed: https://chromium.googlesource.com/chromium/src/+/0c274309d19ab755d13fc41d03be2c28aa21d71d
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|
||||||||||||||||||||||||||||