Fix LG Email workaround criteria.

Fix LG Email workaround criteria.

1) We were accidentally checking Build.VERSION.SDK_INT (version of the
WebView package) when the intent was to check the targetSdkVersion of
the app package itself.  This would come to bite us and globally disable
the workaround when we upgrade the WebView to O.

2) Decrease the APK version check to 67502100 which is the version of
com.lge.email actually shipped on LG V20.  The intent is for the
workaround to be purely grandfathering existing nonupdatable APKs so
there isn't a reason to leave headroom.

3) Take advantage of PackageUtils.getPackageVersion.

BUG=651706, 683294
Review-Url: https://codereview.chromium.org/2643943004
Cr-Commit-Position: refs/heads/master@{#445509}
Committed: https://chromium.googlesource.com/chromium/src/+/9079de0121eb747464e490e29fd2444dde5f0847

[aelias_OOO_until_Jul13, 2017-01-20 00:16:12]

The CQ bit was checked by aelias@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 00:17:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aelias_OOO_until_Jul13, 2017-01-20 00:20:18]

aelias@chromium.org changed reviewers:
+ changwan@chromium.org

[aelias_OOO_until_Jul13, 2017-01-20 00:20:38]

Hi changwan@, PTAL.

[commit-bot: I haz the power, 2017-01-20 00:40:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 00:40:42]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[aelias_OOO_until_Jul13, 2017-01-20 00:44:10]

The CQ bit was checked by aelias@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 00:45:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aelias_OOO_until_Jul13, 2017-01-20 00:51:47]

aelias@chromium.org changed reviewers:
+ torne@chromium.org

[commit-bot: I haz the power, 2017-01-20 01:23:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 01:23:05]

Dry run: This issue passed the CQ dry run.

[Changwan Ryu, 2017-01-20 01:26:32]

lgtm, thanks for fixing this!

[aelias_OOO_until_Jul13, 2017-01-20 01:36:31]

Also need OWNERS from torne@ for android_webview/

[Torne, 2017-01-20 12:02:38]

Are you going to wait until LG confirm there isn't another version out there
somewhere before landing this?

https://codereview.chromium.org/2643943004/diff/20001/content/public/android/...
File
content/public/android/java/src/org/chromium/content/browser/input/LGEmailActionModeWorkaround.java
(right):

https://codereview.chromium.org/2643943004/diff/20001/content/public/android/...
content/public/android/java/src/org/chromium/content/browser/input/LGEmailActionModeWorkaround.java:65:
if (versionCode > 67502100) return false;
Can this version number live somewhere common?

[aelias_OOO_until_Jul13, 2017-01-20 19:15:30]

On 2017/01/20 at 12:02:38, torne wrote:
> Are you going to wait until LG confirm there isn't another version out there
somewhere before landing this?

No, since their implied preference is to leave in the workaround forever, their
incentive if we block landing on their reply is to not answer or to vaguely
object.  If we land, then the path of least resistance for them is to just fix
the issue in their builds, and only if there's actually another nonupdatable
version out there would they go to the effort of arguing with us again.  So I
think the only way to know is to start the rollout process with this version. 
Anyway, I think the risk is low in January of another new OS version down the
pipeline, and I noticed that they finally added the ability to update the LG
Email APK in the N phone I tested.

[aelias_OOO_until_Jul13, 2017-01-20 19:18:40]

https://codereview.chromium.org/2643943004/diff/20001/content/public/android/...
File
content/public/android/java/src/org/chromium/content/browser/input/LGEmailActionModeWorkaround.java
(right):

https://codereview.chromium.org/2643943004/diff/20001/content/public/android/...
content/public/android/java/src/org/chromium/content/browser/input/LGEmailActionModeWorkaround.java:65:
if (versionCode > 67502100) return false;
On 2017/01/20 at 12:02:38, Torne wrote:
> Can this version number live somewhere common?

Done.

[aelias_OOO_until_Jul13, 2017-01-20 19:19:43]

The CQ bit was checked by aelias@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 19:20:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aelias_OOO_until_Jul13, 2017-01-20 19:21:56]

Description was changed from

==========
Fix LG Email workaround criteria.

1) We were accidentally checking Build.VERSION.SDK_INT (version of the
WebView package) when the intent was to check the targetSdkVersion of
the app package itself.  This would come to bite us and globally disable
the workaround when we upgrade the WebView to O.

2) Decrease the APK version check to 67502100 which is the version of
com.lge.email actually shipped on LG V20.  The intent is for the
workaround to be purely grandfathering existing nonupdatable APKs so
there isn't a reason to leave headroom.

3) Take advantage of PackageUtils.getPackageVersion.

BUG=651706
==========

to

==========
Fix LG Email workaround criteria.

1) We were accidentally checking Build.VERSION.SDK_INT (version of the
WebView package) when the intent was to check the targetSdkVersion of
the app package itself.  This would come to bite us and globally disable
the workaround when we upgrade the WebView to O.

2) Decrease the APK version check to 67502100 which is the version of
com.lge.email actually shipped on LG V20.  The intent is for the
workaround to be purely grandfathering existing nonupdatable APKs so
there isn't a reason to leave headroom.

3) Take advantage of PackageUtils.getPackageVersion.

BUG=651706,683294
==========

[commit-bot: I haz the power, 2017-01-20 20:01:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 20:01:04]

Dry run: This issue passed the CQ dry run.

[Torne, 2017-01-23 11:35:20]

On 2017/01/20 19:15:30, aelias wrote:
> On 2017/01/20 at 12:02:38, torne wrote:
> > Are you going to wait until LG confirm there isn't another version out there
> somewhere before landing this?
> 
> No, since their implied preference is to leave in the workaround forever,
their
> incentive if we block landing on their reply is to not answer or to vaguely
> object.  If we land, then the path of least resistance for them is to just fix
> the issue in their builds, and only if there's actually another nonupdatable
> version out there would they go to the effort of arguing with us again.  So I
> think the only way to know is to start the rollout process with this version. 
> Anyway, I think the risk is low in January of another new OS version down the
> pipeline, and I noticed that they finally added the ability to update the LG
> Email APK in the N phone I tested.

OK. LGTM.

[aelias_OOO_until_Jul13, 2017-01-23 21:25:51]

The CQ bit was checked by aelias@chromium.org

[aelias_OOO_until_Jul13, 2017-01-23 21:25:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
changwan@chromium.org
Link to the patchset: https://codereview.chromium.org/2643943004/#ps40001
(title: "Make number common and add Android N targetSdkVersion to thread check")

[commit-bot: I haz the power, 2017-01-23 21:26:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 22:15:40]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485206751838090,
"parent_rev": "57fcaed1785c4172998169286d9e35cfe3021095", "commit_rev":
"9079de0121eb747464e490e29fd2444dde5f0847"}

[commit-bot: I haz the power, 2017-01-23 22:16:13]

Description was changed from

==========
Fix LG Email workaround criteria.

1) We were accidentally checking Build.VERSION.SDK_INT (version of the
WebView package) when the intent was to check the targetSdkVersion of
the app package itself.  This would come to bite us and globally disable
the workaround when we upgrade the WebView to O.

2) Decrease the APK version check to 67502100 which is the version of
com.lge.email actually shipped on LG V20.  The intent is for the
workaround to be purely grandfathering existing nonupdatable APKs so
there isn't a reason to leave headroom.

3) Take advantage of PackageUtils.getPackageVersion.

BUG=651706,683294
==========

to

==========
Fix LG Email workaround criteria.

1) We were accidentally checking Build.VERSION.SDK_INT (version of the
WebView package) when the intent was to check the targetSdkVersion of
the app package itself.  This would come to bite us and globally disable
the workaround when we upgrade the WebView to O.

2) Decrease the APK version check to 67502100 which is the version of
com.lge.email actually shipped on LG V20.  The intent is for the
workaround to be purely grandfathering existing nonupdatable APKs so
there isn't a reason to leave headroom.

3) Take advantage of PackageUtils.getPackageVersion.

BUG=651706,683294

Review-Url: https://codereview.chromium.org/2643943004
Cr-Commit-Position: refs/heads/master@{#445509}
Committed:
https://chromium.googlesource.com/chromium/src/+/9079de0121eb747464e490e29fd2...
==========

[commit-bot: I haz the power, 2017-01-23 22:16:15]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9079de0121eb747464e490e29fd2...