Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Issue 2648763002: CRWWebController no longer implements CRWRequestTrackerDelegate. (Closed)

Created:
3 years, 11 months ago by sdefresne
Modified:
3 years, 11 months ago
CC:
chromium-reviews, Eugene But (OOO till 7-30)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CRWWebController no longer implements CRWRequestTrackerDelegate. Since there is no RequestTracker associated with WebStateImpl, it is no longer necessary for CRWWebController to implement the CRWRequestTrackerDelegate protocol. BUG=585700 Review-Url: https://codereview.chromium.org/2648763002 Cr-Commit-Position: refs/heads/master@{#445092} Committed: https://chromium.googlesource.com/chromium/src/+/df5fd66a97bcf715347ae23a9623e1e7f5201740

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -58 lines) Patch
M ios/web/web_state/ui/crw_web_controller.h View 1 chunk +0 lines, -1 line 0 comments Download
M ios/web/web_state/ui/crw_web_controller.mm View 1 chunk +0 lines, -57 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (9 generated)
sdefresne
Please take a look and send to CQ if LGTY.
3 years, 11 months ago (2017-01-20 12:32:03 UTC) #4
Eugene But (OOO till 7-30)
lgtm
3 years, 11 months ago (2017-01-20 18:08:28 UTC) #9
Eugene But (OOO till 7-30)
Thank you!
3 years, 11 months ago (2017-01-20 18:08:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2648763002/1
3 years, 11 months ago (2017-01-20 18:08:48 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 18:14:15 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/df5fd66a97bcf715347ae23a9623...

Powered by Google App Engine
This is Rietveld 408576698