Add response code to the success callback of ReportSender

components/certificate_reporting/error_reporter_unittest.cc

Index: components/certificate_reporting/error_reporter_unittest.cc
diff --git a/components/certificate_reporting/error_reporter_unittest.cc b/components/certificate_reporting/error_reporter_unittest.cc
index 076049dd916465846a0b63a8dfad64fbf61db82e..7f3350f81b961b06bda564b08b1d868e16fa1eb7 100644
--- a/components/certificate_reporting/error_reporter_unittest.cc
+++ b/components/certificate_reporting/error_reporter_unittest.cc
@@ -38,7 +38,7 @@ void ErrorCallback(bool* called, const GURL& report_uri, int net_error) {
   *called = true;
 }
 
-void SuccessCallback(bool* called) {
+void SuccessCallback(bool* called, int response_code) {
   *called = true;
 }
 
@@ -54,7 +54,7 @@ class MockCertificateReportSender : public net::ReportSender {
       const GURL& report_uri,
       base::StringPiece content_type,
       base::StringPiece report,
-      const base::Callback<void()>& success_callback,
+      const base::Callback<void(int)>& success_callback,
       const base::Callback<void(const GURL&, int)>& error_callback) override {
     latest_report_uri_ = report_uri;
     report.CopyToString(&latest_report_);
@@ -127,7 +127,8 @@ TEST_F(ErrorReporterTest, ExtendedReportingSendReport) {
                                kServerPublicKeyTestVersion,
                                base::WrapUnique(mock_report_sender));
   https_reporter.SendExtendedReportingReport(
-      kDummyReport, base::Closure(), base::Callback<void(const GURL&, int)>());
+      kDummyReport, base::Callback<void(int)>(),

[eroman, 2017/04/25 21:02:39]

Are there any tests for the HTTP code?

[meacer, 2017/04/26 22:27:06]

Added one to report_sender_unittest.cc

+      base::Callback<void(const GURL&, int)>());
   EXPECT_EQ(mock_report_sender->latest_report_uri(), https_url);
   EXPECT_EQ(mock_report_sender->latest_report(), kDummyReport);
 
@@ -139,7 +140,8 @@ TEST_F(ErrorReporterTest, ExtendedReportingSendReport) {
                               kServerPublicKeyTestVersion,
                               base::WrapUnique(http_mock_report_sender));
   http_reporter.SendExtendedReportingReport(
-      kDummyReport, base::Closure(), base::Callback<void(const GURL&, int)>());
+      kDummyReport, base::Callback<void(int)>(),
+      base::Callback<void(const GURL&, int)>());
 
   EXPECT_EQ(http_mock_report_sender->latest_report_uri(), http_url);
   EXPECT_EQ("application/octet-stream",