components/certificate_reporting/error_reporter.cc - Issue 2648713002: Add response code to the success callback of ReportSender

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/certificate_reporting/error_reporter.cc

Issue 2648713002: Add response code to the success callback of ReportSender (Closed)

Patch Set: Remove response code from error callback Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/certificate_reporting/error_reporter.cc

diff --git a/components/certificate_reporting/error_reporter.cc b/components/certificate_reporting/error_reporter.cc

index 3ab3a3c9cecfff76bb58639f623e69a59d2576a7..f6a4f51ea98a1f298030d5a980d93494cc46699d 100644

--- a/components/certificate_reporting/error_reporter.cc

+++ b/components/certificate_reporting/error_reporter.cc

@@ -127,7 +127,7 @@ ErrorReporter::~ErrorReporter() {}

void ErrorReporter::SendExtendedReportingReport(

const std::string& serialized_report,

- const base::Callback<void()>& success_callback,

+ const base::Callback<void(int)>& success_callback,

const base::Callback<void(const GURL&, int)>& error_callback) {

if (upload_url_.SchemeIsCryptographic()) {

certificate_report_sender_->Send(upload_url_, "application/octet-stream",