Add response code to the success callback of ReportSender

components/certificate_reporting/error_reporter_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/certificate_reporting/error_reporter.h"
 
 #include <stdint.h>
 #include <string.h>
 
 #include <set>
@@ skipping 20 matching lines @@
 const char kDummyHttpReportUri[] = "http://example.test";
 const char kDummyHttpsReportUri[] = "https://example.test";
 const char kDummyReport[] = "a dummy report";
 const uint32_t kServerPublicKeyTestVersion = 16;
 
 void ErrorCallback(bool* called, const GURL& report_uri, int net_error) {
   EXPECT_NE(net::OK, net_error);
   *called = true;
 }
 
-void SuccessCallback(bool* called) {
+void SuccessCallback(bool* called, int response_code) {
   *called = true;
 }
 
 // A mock ReportSender that keeps track of the last report
 // sent.
 class MockCertificateReportSender : public net::ReportSender {
  public:
   MockCertificateReportSender()
       : net::ReportSender(nullptr, DO_NOT_SEND_COOKIES) {}
   ~MockCertificateReportSender() override {}
 
   void Send(
       const GURL& report_uri,
       base::StringPiece content_type,
       base::StringPiece report,
-      const base::Callback<void()>& success_callback,
+      const base::Callback<void(int)>& success_callback,
       const base::Callback<void(const GURL&, int)>& error_callback) override {
     latest_report_uri_ = report_uri;
     report.CopyToString(&latest_report_);
     content_type.CopyToString(&latest_content_type_);
   }
 
   const GURL& latest_report_uri() const { return latest_report_uri_; }
 
   const std::string& latest_report() const { return latest_report_; }
 
@@ skipping 52 matching lines @@
 // an encrypted or plaintext extended reporting report as appropriate.
 TEST_F(ErrorReporterTest, ExtendedReportingSendReport) {
   // Data should not be encrypted when sent to an HTTPS URL.
   MockCertificateReportSender* mock_report_sender =
       new MockCertificateReportSender();
   GURL https_url(kDummyHttpsReportUri);
   ErrorReporter https_reporter(https_url, server_public_key_,
                                kServerPublicKeyTestVersion,
                                base::WrapUnique(mock_report_sender));
   https_reporter.SendExtendedReportingReport(
-      kDummyReport, base::Closure(), base::Callback<void(const GURL&, int)>());
+      kDummyReport, base::Callback<void(int)>(),

[eroman, 2017/04/25 21:02:39]

Are there any tests for the HTTP code?

[meacer, 2017/04/26 22:27:06]

Added one to report_sender_unittest.cc

+      base::Callback<void(const GURL&, int)>());
   EXPECT_EQ(mock_report_sender->latest_report_uri(), https_url);
   EXPECT_EQ(mock_report_sender->latest_report(), kDummyReport);
 
   // Data should be encrypted when sent to an HTTP URL.
   MockCertificateReportSender* http_mock_report_sender =
       new MockCertificateReportSender();
   GURL http_url(kDummyHttpReportUri);
   ErrorReporter http_reporter(http_url, server_public_key_,
                               kServerPublicKeyTestVersion,
                               base::WrapUnique(http_mock_report_sender));
   http_reporter.SendExtendedReportingReport(
-      kDummyReport, base::Closure(), base::Callback<void(const GURL&, int)>());
+      kDummyReport, base::Callback<void(int)>(),
+      base::Callback<void(const GURL&, int)>());
 
   EXPECT_EQ(http_mock_report_sender->latest_report_uri(), http_url);
   EXPECT_EQ("application/octet-stream",
             http_mock_report_sender->latest_content_type());
 
   std::string uploaded_report;
   EncryptedCertLoggerRequest encrypted_request;
   ASSERT_TRUE(encrypted_request.ParseFromString(
       http_mock_report_sender->latest_report()));
   EXPECT_EQ(kServerPublicKeyTestVersion,
@@ skipping 215 matching lines @@
   ASSERT_TRUE(encrypted_request.ParseFromString(
       std::string(reinterpret_cast<const char*>(kSerializedEncryptedReport),
                   sizeof(kSerializedEncryptedReport))));
   ASSERT_TRUE(ErrorReporter::DecryptErrorReport(
       server_private_key_, encrypted_request, &decrypted_serialized_report));
 }
 
 }  // namespace
 
 }  // namespace certificate_reporting