Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: components/certificate_reporting/error_reporter.cc

Issue 2648713002: Add response code to the success callback of ReportSender (Closed)
Patch Set: Remove response code from error callback Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/certificate_reporting/error_reporter.h" 5 #include "components/certificate_reporting/error_reporter.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
120 server_public_key_(server_public_key), 120 server_public_key_(server_public_key),
121 server_public_key_version_(server_public_key_version) { 121 server_public_key_version_(server_public_key_version) {
122 DCHECK(certificate_report_sender_); 122 DCHECK(certificate_report_sender_);
123 DCHECK(!upload_url.is_empty()); 123 DCHECK(!upload_url.is_empty());
124 } 124 }
125 125
126 ErrorReporter::~ErrorReporter() {} 126 ErrorReporter::~ErrorReporter() {}
127 127
128 void ErrorReporter::SendExtendedReportingReport( 128 void ErrorReporter::SendExtendedReportingReport(
129 const std::string& serialized_report, 129 const std::string& serialized_report,
130 const base::Callback<void()>& success_callback, 130 const base::Callback<void(int)>& success_callback,
131 const base::Callback<void(const GURL&, int)>& error_callback) { 131 const base::Callback<void(const GURL&, int)>& error_callback) {
132 if (upload_url_.SchemeIsCryptographic()) { 132 if (upload_url_.SchemeIsCryptographic()) {
133 certificate_report_sender_->Send(upload_url_, "application/octet-stream", 133 certificate_report_sender_->Send(upload_url_, "application/octet-stream",
134 serialized_report, success_callback, 134 serialized_report, success_callback,
135 error_callback); 135 error_callback);
136 return; 136 return;
137 } 137 }
138 EncryptedCertLoggerRequest encrypted_report; 138 EncryptedCertLoggerRequest encrypted_report;
139 if (!EncryptSerializedReport(server_public_key_, server_public_key_version_, 139 if (!EncryptSerializedReport(server_public_key_, server_public_key_version_,
140 serialized_report, &encrypted_report)) { 140 serialized_report, &encrypted_report)) {
(...skipping 24 matching lines...) Expand all
165 aead.Init(&key); 165 aead.Init(&key);
166 166
167 // Use an all-zero nonce because the key is random per-message. 167 // Use an all-zero nonce because the key is random per-message.
168 std::string nonce(aead.NonceLength(), 0); 168 std::string nonce(aead.NonceLength(), 0);
169 169
170 return aead.Open(encrypted_report.encrypted_report(), nonce, std::string(), 170 return aead.Open(encrypted_report.encrypted_report(), nonce, std::string(),
171 decrypted_serialized_report); 171 decrypted_serialized_report);
172 } 172 }
173 173
174 } // namespace certificate_reporting 174 } // namespace certificate_reporting
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698