Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(818)

Unified Diff: net/http/http_stream_factory_impl_job_controller.cc

Issue 2648593002: Allow a preconnecting job to a HTTP2 proxy server based on privacy mode (Closed)
Patch Set: ps Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_stream_factory_impl_job_controller.cc
diff --git a/net/http/http_stream_factory_impl_job_controller.cc b/net/http/http_stream_factory_impl_job_controller.cc
index c72fd3db7148254fa21964d411d9c5f363b138f9..17b93f0e522e15261646a61bc1295389ddafeffe 100644
--- a/net/http/http_stream_factory_impl_job_controller.cc
+++ b/net/http/http_stream_factory_impl_job_controller.cc
@@ -52,6 +52,7 @@ HttpStreamFactoryImpl::JobController::JobController(
main_job_is_blocked_(false),
bound_job_(nullptr),
can_start_alternative_proxy_job_(false),
+ privacy_mode_(PRIVACY_MODE_DISABLED),
ptr_factory_(this) {
DCHECK(factory);
}
@@ -79,6 +80,8 @@ HttpStreamFactoryImpl::Request* HttpStreamFactoryImpl::JobController::Start(
DCHECK(factory_);
DCHECK(!request_);
+ privacy_mode_ = request_info.privacy_mode;
+
request_ = new Request(request_info.url, this, delegate,
websocket_handshake_stream_create_helper, net_log,
stream_type);
@@ -97,6 +100,8 @@ void HttpStreamFactoryImpl::JobController::Preconnect(
DCHECK(!main_job_);
DCHECK(!alternative_job_);
+ privacy_mode_ = request_info.privacy_mode;
+
is_preconnect_ = true;
HostPortPair destination(HostPortPair::FromURL(request_info.url));
GURL origin_url = ApplyHostMappingRules(request_info.url, &destination);
@@ -186,7 +191,7 @@ void HttpStreamFactoryImpl::JobController::OnStreamReady(
const SSLConfig& used_ssl_config) {
DCHECK(job);
- factory_->OnStreamReady(job->proxy_info());
+ factory_->OnStreamReady(job->proxy_info(), privacy_mode_);
if (IsJobOrphaned(job)) {
// We have bound a job to the associated Request, |job| has been orphaned.
@@ -382,7 +387,7 @@ void HttpStreamFactoryImpl::JobController::OnNeedsProxyAuth(
bool HttpStreamFactoryImpl::JobController::OnInitConnection(
const ProxyInfo& proxy_info) {
- return factory_->OnInitConnection(*this, proxy_info);
+ return factory_->OnInitConnection(*this, proxy_info, privacy_mode_);
}
void HttpStreamFactoryImpl::JobController::OnResolveProxyComplete(

Powered by Google App Engine
This is Rietveld 408576698