Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2648423005: [sensors][win] Use angular velocity values for gyroscope sensor (Closed)

Created:
3 years, 11 months ago by shalamov
Modified:
3 years, 11 months ago
CC:
chromium-reviews, wanming.lin, Mikhail
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[sensors][win] Use angular velocity values for gyroscope sensor This CL aligns implementation of gyroscope sensor with the specification and uses angular velocity reading values instead of angular acceleration. Unit tests updated to verify changes. BUG=669765 Review-Url: https://codereview.chromium.org/2648423005 Cr-Commit-Position: refs/heads/master@{#445974} Committed: https://chromium.googlesource.com/chromium/src/+/988f519584a682a2191c6ca72f91380f91d8166a

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rename constant #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -34 lines) Patch
M device/generic_sensor/generic_sensor_consts.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M device/generic_sensor/linux/sensor_data_linux.cc View 1 1 chunk +8 lines, -8 lines 0 comments Download
M device/generic_sensor/platform_sensor_and_provider_unittest_linux.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M device/generic_sensor/platform_sensor_and_provider_unittest_win.cc View 1 1 chunk +6 lines, -12 lines 0 comments Download
M device/generic_sensor/platform_sensor_reader_win.cc View 1 1 chunk +10 lines, -10 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
shalamov
PTAL
3 years, 11 months ago (2017-01-24 14:22:25 UTC) #4
Mikhail
lgtm https://codereview.chromium.org/2648423005/diff/1/device/generic_sensor/platform_sensor_reader_win.cc File device/generic_sensor/platform_sensor_reader_win.cc (right): https://codereview.chromium.org/2648423005/diff/1/device/generic_sensor/platform_sensor_reader_win.cc#newcode126 device/generic_sensor/platform_sensor_reader_win.cc:126: reading.values[0] = -x * kRadiansInDegreesPerSecond; s/kRadiansInDegreesPerSecond/kRadiansInDegrees
3 years, 11 months ago (2017-01-24 14:24:48 UTC) #5
Reilly Grant (use Gerrit)
lgtm but please check that you have the right issue number in the BUG= line. ...
3 years, 11 months ago (2017-01-24 20:05:15 UTC) #10
shalamov
On 2017/01/24 20:05:15, Reilly Grant wrote: > lgtm but please check that you have the ...
3 years, 11 months ago (2017-01-25 07:20:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2648423005/20001
3 years, 11 months ago (2017-01-25 07:20:58 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 07:26:11 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/988f519584a682a2191c6ca72f91...

Powered by Google App Engine
This is Rietveld 408576698