device/generic_sensor/platform_sensor_and_provider_unittest_linux.cc - Issue 2648423005: [sensors][win] Use angular velocity values for gyroscope sensor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/generic_sensor/platform_sensor_and_provider_unittest_linux.cc

Issue 2648423005: [sensors][win] Use angular velocity values for gyroscope sensor (Closed)

Patch Set: Rename constant Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « device/generic_sensor/linux/sensor_data_linux.cc ('k') | device/generic_sensor/platform_sensor_and_provider_unittest_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/generic_sensor/platform_sensor_and_provider_unittest_linux.cc

diff --git a/device/generic_sensor/platform_sensor_and_provider_unittest_linux.cc b/device/generic_sensor/platform_sensor_and_provider_unittest_linux.cc

index 5e89b40ce05dc8c057a7da7c66bdc0b5e1947f16..fba5e1d833728ca22e0750c7e12363bdd566c037 100644

--- a/device/generic_sensor/platform_sensor_and_provider_unittest_linux.cc

+++ b/device/generic_sensor/platform_sensor_and_provider_unittest_linux.cc

@@ -594,8 +594,7 @@ TEST_F(PlatformSensorAndProviderLinuxTest, CheckGyroscopeReadingConversion) {

SensorReadingSharedBuffer* buffer =

static_cast<SensorReadingSharedBuffer*>(mapping.get());

#if defined(OS_CHROMEOS)

- double scaling =

- kMeanGravity * kRadiansInDegreesPerSecond / kGyroscopeScalingValue;

+ double scaling = kMeanGravity * kRadiansInDegrees / kGyroscopeScalingValue;

EXPECT_THAT(buffer->reading.values[0], -scaling * sensor_values[0]);

EXPECT_THAT(buffer->reading.values[1], -scaling * sensor_values[1]);

EXPECT_THAT(buffer->reading.values[2], -scaling * sensor_values[2]);