Add effective connection type to throughput mapping

Add effective connection type to throughput mapping

Add effective connection type to throughput mapping for Network Quality
Estimator (NQE).

BUG=684137
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2648353003
Cr-Commit-Position: refs/heads/master@{#446723}
Committed: https://chromium.googlesource.com/chromium/src/+/22ab374ddc2e729b0b914e8774b11233438e29ea

[tbansal1, 2017-01-23 23:31:22]

Description was changed from

==========
Add typical nq

BUG=
==========

to

==========
Add typical nq

BUG=684137

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[tbansal1, 2017-01-24 00:13:27]

Description was changed from

==========
Add typical nq

BUG=684137

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
Add effective connection type to throughput mapping

Add effective connection type to throughput mapping for Network Quality
Estimator (NQE).

BUG=684137

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[tbansal1, 2017-01-24 00:13:50]

tbansal@chromium.org changed reviewers:
+ ryansturm@chromium.org

[tbansal1, 2017-01-24 00:13:50]

ryansturm: ptal. Thanks.

[tbansal1, 2017-01-24 00:14:00]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 00:14:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 01:19:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 01:19:16]

Dry run: This issue passed the CQ dry run.

[RyanSturm, 2017-01-25 19:15:34]

https://codereview.chromium.org/2648353003/diff/1/net/nqe/network_quality_est...
File net/nqe/network_quality_estimator.cc (right):

https://codereview.chromium.org/2648353003/diff/1/net/nqe/network_quality_est...
net/nqe/network_quality_estimator.cc:1440: ComputeEffectiveConnectionType();
If the computed type doesn't change from the ect on line 1407, this will no
longer call NotifyObserversOfEffectiveConnectionTypeChanged(). that seems wrong.

https://codereview.chromium.org/2648353003/diff/1/net/nqe/network_quality_est...
File net/nqe/network_quality_estimator_params.cc (right):

https://codereview.chromium.org/2648353003/diff/1/net/nqe/network_quality_est...
net/nqe/network_quality_estimator_params.cc:235: // Set to the 77.5th percentile
of 2G RTT observations on Android. This
nit: 77.5th percentile sounds pretty weird to me. I'm not sure 775th permilles
is better (I don't know if people know what a permille is just by casual
reading), but it is more accurate.

[tbansal1, 2017-01-26 21:54:48]

Patchset #2 (id:20001) has been deleted

[tbansal1, 2017-01-26 22:00:06]

ryansturm: ptal. Thanks.

https://codereview.chromium.org/2648353003/diff/1/net/nqe/network_quality_est...
File net/nqe/network_quality_estimator.cc (right):

https://codereview.chromium.org/2648353003/diff/1/net/nqe/network_quality_est...
net/nqe/network_quality_estimator.cc:1440: ComputeEffectiveConnectionType();
On 2017/01/25 19:15:34, Ryan Sturm wrote:
> If the computed type doesn't change from the ect on line 1407, this will no
> longer call NotifyObserversOfEffectiveConnectionTypeChanged(). that seems
wrong.

I removed that unnecessary code. ComputeECT() function calls
NotifyObserversOfEffectiveConnectionTypeChanged() internally.

https://codereview.chromium.org/2648353003/diff/1/net/nqe/network_quality_est...
File net/nqe/network_quality_estimator_params.cc (right):

https://codereview.chromium.org/2648353003/diff/1/net/nqe/network_quality_est...
net/nqe/network_quality_estimator_params.cc:235: // Set to the 77.5th percentile
of 2G RTT observations on Android. This
On 2017/01/25 19:15:34, Ryan Sturm wrote:
> nit: 77.5th percentile sounds pretty weird to me. I'm not sure 775th permilles
> is better (I don't know if people know what a permille is just by casual
> reading), but it is more accurate.

Seems like not super-important. I can call it permilles if you feel strongly
about it.

[tbansal1, 2017-01-26 22:01:19]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-26 22:02:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 00:00:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 00:00:23]

Dry run: This issue passed the CQ dry run.

[RyanSturm, 2017-01-27 18:43:16]

lgtm. Talked offline about adding UMA for tracking cache accuracy WRT weighting
cache entires (currently the cached values are weighted very little, but UMA
could reveal that they should be weighted more or effectively zero as soon as a
new value comes in).

[tbansal1, 2017-01-27 18:43:57]

The CQ bit was checked by tbansal@chromium.org

[commit-bot: I haz the power, 2017-01-27 18:44:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 18:49:26]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1485542637673430,
"parent_rev": "b010297ff1f816371c5ca93dbe5400ddff6fb3fd", "commit_rev":
"22ab374ddc2e729b0b914e8774b11233438e29ea"}

[commit-bot: I haz the power, 2017-01-27 18:50:00]

Description was changed from

==========
Add effective connection type to throughput mapping

Add effective connection type to throughput mapping for Network Quality
Estimator (NQE).

BUG=684137

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
Add effective connection type to throughput mapping

Add effective connection type to throughput mapping for Network Quality
Estimator (NQE).

BUG=684137

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2648353003
Cr-Commit-Position: refs/heads/master@{#446723}
Committed:
https://chromium.googlesource.com/chromium/src/+/22ab374ddc2e729b0b914e8774b1...
==========

[commit-bot: I haz the power, 2017-01-27 18:50:03]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/22ab374ddc2e729b0b914e8774b1...