Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2648353003: Add effective connection type to throughput mapping (Closed)

Created:
3 years, 11 months ago by tbansal1
Modified:
3 years, 10 months ago
Reviewers:
RyanSturm
CC:
chromium-reviews, cbentzel+watch_chromium.org, tbansal+watch-nqe_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add effective connection type to throughput mapping Add effective connection type to throughput mapping for Network Quality Estimator (NQE). BUG=684137 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2648353003 Cr-Commit-Position: refs/heads/master@{#446723} Committed: https://chromium.googlesource.com/chromium/src/+/22ab374ddc2e729b0b914e8774b11233438e29ea

Patch Set 1 #

Total comments: 4

Patch Set 2 : Rebased #

Patch Set 3 : ryansturm comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -24 lines) Patch
M net/nqe/network_quality_estimator.cc View 1 2 2 chunks +1 line, -11 lines 0 comments Download
M net/nqe/network_quality_estimator_params.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M net/nqe/network_quality_estimator_unittest.cc View 1 2 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 21 (15 generated)
tbansal1
ryansturm: ptal. Thanks.
3 years, 11 months ago (2017-01-24 00:13:50 UTC) #4
RyanSturm
https://codereview.chromium.org/2648353003/diff/1/net/nqe/network_quality_estimator.cc File net/nqe/network_quality_estimator.cc (right): https://codereview.chromium.org/2648353003/diff/1/net/nqe/network_quality_estimator.cc#newcode1440 net/nqe/network_quality_estimator.cc:1440: ComputeEffectiveConnectionType(); If the computed type doesn't change from the ...
3 years, 10 months ago (2017-01-25 19:15:34 UTC) #9
tbansal1
ryansturm: ptal. Thanks. https://codereview.chromium.org/2648353003/diff/1/net/nqe/network_quality_estimator.cc File net/nqe/network_quality_estimator.cc (right): https://codereview.chromium.org/2648353003/diff/1/net/nqe/network_quality_estimator.cc#newcode1440 net/nqe/network_quality_estimator.cc:1440: ComputeEffectiveConnectionType(); On 2017/01/25 19:15:34, Ryan Sturm ...
3 years, 10 months ago (2017-01-26 22:00:06 UTC) #11
RyanSturm
lgtm. Talked offline about adding UMA for tracking cache accuracy WRT weighting cache entires (currently ...
3 years, 10 months ago (2017-01-27 18:43:16 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2648353003/60001
3 years, 10 months ago (2017-01-27 18:44:18 UTC) #18
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 18:50:03 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/22ab374ddc2e729b0b914e8774b1...

Powered by Google App Engine
This is Rietveld 408576698