Add effective connection type to throughput mapping

net/nqe/network_quality_estimator_params.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/nqe/network_quality_estimator_params.h"
 
 #include <stdint.h>
 
 #include "base/strings/string_number_conversions.h"
 #include "base/time/time.h"
@@ skipping 214 matching lines @@
 
 void ObtainTypicalNetworkQuality(NetworkQuality typical_network_quality[]) {
   for (size_t i = 0; i < EFFECTIVE_CONNECTION_TYPE_LAST; ++i) {
     DCHECK_EQ(InvalidRTT(), typical_network_quality[i].http_rtt());
     DCHECK_EQ(InvalidRTT(), typical_network_quality[i].transport_rtt());
     DCHECK_EQ(kInvalidThroughput,
               typical_network_quality[i].downstream_throughput_kbps());
   }
 
   typical_network_quality[EFFECTIVE_CONNECTION_TYPE_SLOW_2G] = NetworkQuality(
-      // Set to the 83rd percentile of 2G RTT observations on Android. This
+      // Set to the 77.5th percentile of 2G RTT observations on Android. This

[RyanSturm, 2017/01/25 19:15:34]

nit: 77.5th percentile sounds pretty weird to me. I'm not sure 775th permilles
is better (I don't know if people know what a permille is just by casual
reading), but it is more accurate.

[tbansal1, 2017/01/26 22:00:05]

Seems like not super-important. I can call it permilles if you feel strongly
about it.

       // corresponds to the median RTT observation when effective connection
       // type is Slow 2G.
       base::TimeDelta::FromMilliseconds(3600),
-      base::TimeDelta::FromMilliseconds(3000), kInvalidThroughput);
+      base::TimeDelta::FromMilliseconds(3000), 40);
 
   typical_network_quality[EFFECTIVE_CONNECTION_TYPE_2G] = NetworkQuality(
       // Set to the 58th percentile of 2G RTT observations on Android. This
       // corresponds to the median RTT observation when effective connection
       // type is 2G.
       base::TimeDelta::FromMilliseconds(1800),
-      base::TimeDelta::FromMilliseconds(1500), kInvalidThroughput);
+      base::TimeDelta::FromMilliseconds(1500), 75);
 
   typical_network_quality[EFFECTIVE_CONNECTION_TYPE_3G] = NetworkQuality(
       // Set to the 75th percentile of 3G RTT observations on Android. This
       // corresponds to the median RTT observation when effective connection
       // type is 3G.
       base::TimeDelta::FromMilliseconds(450),
-      base::TimeDelta::FromMilliseconds(400), kInvalidThroughput);
+      base::TimeDelta::FromMilliseconds(400), 400);
 
   // Set to the 25th percentile of 3G RTT observations on Android.
-  typical_network_quality[EFFECTIVE_CONNECTION_TYPE_4G] = NetworkQuality(
-      base::TimeDelta::FromMilliseconds(175),
-      base::TimeDelta::FromMilliseconds(125), kInvalidThroughput);
+  typical_network_quality[EFFECTIVE_CONNECTION_TYPE_4G] =
+      NetworkQuality(base::TimeDelta::FromMilliseconds(175),
+                     base::TimeDelta::FromMilliseconds(125), 1600);
 
   static_assert(
       EFFECTIVE_CONNECTION_TYPE_4G + 1 == EFFECTIVE_CONNECTION_TYPE_LAST,
       "Missing effective connection type");
 }
 
 void ObtainEffectiveConnectionTypeModelParams(
     const std::map<std::string, std::string>& variation_params,
     NetworkQuality connection_thresholds[]) {
   // First set the default thresholds.
@@ skipping 98 matching lines @@
   (void)effective_connection_type_available;
 
   return forced_effective_connection_type;
 }
 
 }  // namespace internal
 
 }  // namespace nqe
 
 }  // namespace net