Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2648343004: Don't paint selections in <mask>s, <clipPath>s and <pattern>s (Closed)

Created:
3 years, 11 months ago by fs
Modified:
3 years, 10 months ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, krit, eae+blinkwatch, f(malita), fs, gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+svgwatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't paint selections in <mask>s, <clipPath>s and <pattern>s Painting a selection within a <mask>, <clipPath> or <pattern> can trigger a client "style change" to update the resource cache with whatever the selection style refers to. This "style change" signal will trigger a layout on the resource's clients while painting. Since painting selections within these types of resources, add a PaintLayerFlag and use it to disable selection painting in these cases. Include the painting of elements references from feImage as well under the same umbrella. BUG=683388 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2648343004 Cr-Commit-Position: refs/heads/master@{#446318} Committed: https://chromium.googlesource.com/chromium/src/+/08d2857e7529247a40eb631e108147d8b8374485

Patch Set 1 #

Patch Set 2 : Rebase #

Messages

Total messages: 18 (14 generated)
fs
3 years, 11 months ago (2017-01-24 17:36:51 UTC) #7
pdr.
LGTM
3 years, 10 months ago (2017-01-25 18:35:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2648343004/20001
3 years, 10 months ago (2017-01-26 14:12:26 UTC) #15
commit-bot: I haz the power
3 years, 10 months ago (2017-01-26 14:16:57 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/08d2857e7529247a40eb631e1081...

Powered by Google App Engine
This is Rietveld 408576698