Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Side by Side Diff: third_party/WebKit/Source/core/paint/SVGPaintContext.cpp

Issue 2648343004: Don't paint selections in <mask>s, <clipPath>s and <pattern>s (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Rob Buis <buis@kde.org> 2 * Copyright (C) 2007, 2008 Rob Buis <buis@kde.org>
3 * Copyright (C) 2007 Nikolas Zimmermann <zimmermann@kde.org> 3 * Copyright (C) 2007 Nikolas Zimmermann <zimmermann@kde.org>
4 * Copyright (C) 2007 Eric Seidel <eric@webkit.org> 4 * Copyright (C) 2007 Eric Seidel <eric@webkit.org>
5 * Copyright (C) 2009 Google, Inc. All rights reserved. 5 * Copyright (C) 2009 Google, Inc. All rights reserved.
6 * Copyright (C) 2009 Dirk Schulze <krit@webkit.org> 6 * Copyright (C) 2009 Dirk Schulze <krit@webkit.org>
7 * Copyright (C) Research In Motion Limited 2009-2010. All rights reserved. 7 * Copyright (C) Research In Motion Limited 2009-2010. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 206 matching lines...) Expand 10 before | Expand all | Expand 10 after
217 return true; 217 return true;
218 return false; 218 return false;
219 } 219 }
220 220
221 void SVGPaintContext::paintSubtree(GraphicsContext& context, 221 void SVGPaintContext::paintSubtree(GraphicsContext& context,
222 const LayoutObject* item) { 222 const LayoutObject* item) {
223 DCHECK(item); 223 DCHECK(item);
224 DCHECK(!item->needsLayout()); 224 DCHECK(!item->needsLayout());
225 225
226 PaintInfo info(context, LayoutRect::infiniteIntRect(), PaintPhaseForeground, 226 PaintInfo info(context, LayoutRect::infiniteIntRect(), PaintPhaseForeground,
227 GlobalPaintNormalPhase, PaintLayerNoFlag); 227 GlobalPaintNormalPhase,
228 PaintLayerPaintingRenderingResourceSubtree);
228 item->paint(info, IntPoint()); 229 item->paint(info, IntPoint());
229 } 230 }
230 231
231 bool SVGPaintContext::paintForLayoutObject( 232 bool SVGPaintContext::paintForLayoutObject(
232 const PaintInfo& paintInfo, 233 const PaintInfo& paintInfo,
233 const ComputedStyle& style, 234 const ComputedStyle& style,
234 const LayoutObject& layoutObject, 235 const LayoutObject& layoutObject,
235 LayoutSVGResourceMode resourceMode, 236 LayoutSVGResourceMode resourceMode,
236 SkPaint& paint, 237 SkPaint& paint,
237 const AffineTransform* additionalPaintServerTransform) { 238 const AffineTransform* additionalPaintServerTransform) {
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
269 // though. 270 // though.
270 // Additionally, it's not really safe/guaranteed to be correct, as 271 // Additionally, it's not really safe/guaranteed to be correct, as
271 // something down the paint pipe may want to farther tweak the color 272 // something down the paint pipe may want to farther tweak the color
272 // filter, which could yield incorrect results. (Consider just using 273 // filter, which could yield incorrect results. (Consider just using
273 // saveLayer() w/ this color filter explicitly instead.) 274 // saveLayer() w/ this color filter explicitly instead.)
274 paint.setColorFilter(sk_ref_sp(paintInfo.context.getColorFilter())); 275 paint.setColorFilter(sk_ref_sp(paintInfo.context.getColorFilter()));
275 return true; 276 return true;
276 } 277 }
277 278
278 } // namespace blink 279 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698