Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2648263004: Media Controls: do not handle any event if no controls should be visible. (Closed)

Created:
3 years, 11 months ago by mlamouri (slow - plz ping)
Modified:
3 years, 11 months ago
Reviewers:
whywhat
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Media Controls: do not handle any event if no controls should be visible. This is fixing a regression where a tap on a video without controls would not be received by the page. BUG=675312 R=avayvod@chromium.org Review-Url: https://codereview.chromium.org/2643723003 Cr-Commit-Position: refs/heads/master@{#444703} (cherry picked from commit 47fb183f3d579aed696376053b74e691618d3cf2) Review-Url: https://codereview.chromium.org/2648263004 . Cr-Commit-Position: refs/branch-heads/2924@{#845} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} Committed: https://chromium.googlesource.com/chromium/src/+/72f48baaff975055c0c934fbfc997b47685faafd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/media/video-no-controls-events-not-absorbed.html View 1 chunk +27 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/shadow/MediaControls.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
mlamouri (slow - plz ping)
Committed patchset #1 (id:1) manually as 72f48baaff975055c0c934fbfc997b47685faafd.
3 years, 11 months ago (2017-01-23 20:54:53 UTC) #2
whywhat
3 years, 11 months ago (2017-01-24 00:31:27 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698