Media Controls: do not handle any event if no controls should be visible.

Media Controls: do not handle any event if no controls should be visible.

This is fixing a regression where a tap on a video without controls
would not be received by the page.

BUG=675312
R=avayvod@chromium.org

Review-Url: https://codereview.chromium.org/2643723003
Cr-Commit-Position: refs/heads/master@{#444703}
Committed: https://chromium.googlesource.com/chromium/src/+/47fb183f3d579aed696376053b74e691618d3cf2

[mlamouri (slow - plz ping), 2017-01-18 12:37:44]

The CQ bit was checked by mlamouri@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 12:38:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mlamouri (slow - plz ping), 2017-01-18 13:43:35]

PTAL

[commit-bot: I haz the power, 2017-01-18 14:27:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 14:27:09]

Dry run: This issue passed the CQ dry run.

[whywhat, 2017-01-18 19:37:17]

lgtm

https://codereview.chromium.org/2643723003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/media/video-no-controls-events-not-absorbed.html
(right):

https://codereview.chromium.org/2643723003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/video-no-controls-events-not-absorbed.html:8:
test(_ => {
nit: blank line before?

https://codereview.chromium.org/2643723003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/video-no-controls-events-not-absorbed.html:14:
video.addEventListener('loadedmetadata', t.step_func(_ => {
won't this fail on low-end devices?

[mlamouri (slow - plz ping), 2017-01-19 10:51:00]

The CQ bit was checked by mlamouri@chromium.org

[mlamouri (slow - plz ping), 2017-01-19 10:51:01]

https://codereview.chromium.org/2643723003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/media/video-no-controls-events-not-absorbed.html
(right):

https://codereview.chromium.org/2643723003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/video-no-controls-events-not-absorbed.html:14:
video.addEventListener('loadedmetadata', t.step_func(_ => {
On 2017/01/18 at 19:37:17, whywhat wrote:
> won't this fail on low-end devices?

I think most of the media/ tests wouldn't work on low end devices because they
rely on the loading happening without a gesture :)

[commit-bot: I haz the power, 2017-01-19 10:51:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 10:54:58]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484823060331970, "parent_rev":
"1a0f61231637ff47dc982aa8f6016e68053c3975", "commit_rev":
"47fb183f3d579aed696376053b74e691618d3cf2"}

[commit-bot: I haz the power, 2017-01-19 10:55:32]

Description was changed from

==========
Media Controls: do not handle any event if no controls should be visible.

This is fixing a regression where a tap on a video without controls
would not be received by the page.

BUG=675312
R=avayvod@chromium.org
==========

to

==========
Media Controls: do not handle any event if no controls should be visible.

This is fixing a regression where a tap on a video without controls
would not be received by the page.

BUG=675312
R=avayvod@chromium.org

Review-Url: https://codereview.chromium.org/2643723003
Cr-Commit-Position: refs/heads/master@{#444703}
Committed:
https://chromium.googlesource.com/chromium/src/+/47fb183f3d579aed696376053b74...
==========

[commit-bot: I haz the power, 2017-01-19 10:55:33]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/47fb183f3d579aed696376053b74...