Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2643723003: Media Controls: do not handle any event if no controls should be visible. (Closed)

Created:
3 years, 11 months ago by mlamouri (slow - plz ping)
Modified:
3 years, 11 months ago
Reviewers:
whywhat
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, mlamouri+watch-blink_chromium.org, posciak+watch_chromium.org, nessy, Srirama, vcarbune.chromium
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Media Controls: do not handle any event if no controls should be visible. This is fixing a regression where a tap on a video without controls would not be received by the page. BUG=675312 R=avayvod@chromium.org Review-Url: https://codereview.chromium.org/2643723003 Cr-Commit-Position: refs/heads/master@{#444703} Committed: https://chromium.googlesource.com/chromium/src/+/47fb183f3d579aed696376053b74e691618d3cf2

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/media/video-no-controls-events-not-absorbed.html View 1 chunk +27 lines, -0 lines 3 comments Download
M third_party/WebKit/Source/core/html/shadow/MediaControls.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
mlamouri (slow - plz ping)
PTAL
3 years, 11 months ago (2017-01-18 13:43:35 UTC) #3
whywhat
lgtm https://codereview.chromium.org/2643723003/diff/1/third_party/WebKit/LayoutTests/media/video-no-controls-events-not-absorbed.html File third_party/WebKit/LayoutTests/media/video-no-controls-events-not-absorbed.html (right): https://codereview.chromium.org/2643723003/diff/1/third_party/WebKit/LayoutTests/media/video-no-controls-events-not-absorbed.html#newcode8 third_party/WebKit/LayoutTests/media/video-no-controls-events-not-absorbed.html:8: test(_ => { nit: blank line before? https://codereview.chromium.org/2643723003/diff/1/third_party/WebKit/LayoutTests/media/video-no-controls-events-not-absorbed.html#newcode14 ...
3 years, 11 months ago (2017-01-18 19:37:17 UTC) #6
mlamouri (slow - plz ping)
https://codereview.chromium.org/2643723003/diff/1/third_party/WebKit/LayoutTests/media/video-no-controls-events-not-absorbed.html File third_party/WebKit/LayoutTests/media/video-no-controls-events-not-absorbed.html (right): https://codereview.chromium.org/2643723003/diff/1/third_party/WebKit/LayoutTests/media/video-no-controls-events-not-absorbed.html#newcode14 third_party/WebKit/LayoutTests/media/video-no-controls-events-not-absorbed.html:14: video.addEventListener('loadedmetadata', t.step_func(_ => { On 2017/01/18 at 19:37:17, whywhat ...
3 years, 11 months ago (2017-01-19 10:51:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2643723003/1
3 years, 11 months ago (2017-01-19 10:51:16 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 10:55:33 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/47fb183f3d579aed696376053b74...

Powered by Google App Engine
This is Rietveld 408576698