Add missing permission for webview tests

Add missing permission for webview tests and remove OS specific #ifdef in getUserMedia code.

The reason for the failures on android turned out to be because of the test configuration and not the getUserMedia code. The failure we were hitting was in AndroidAudioManager.java where it turned out that the MODIFY_AUDIO_SETTINGS was missing from the manifest.

See: https://cs.chromium.org/chromium/src/media/base/android/java/src/org/chromium/media/AudioManagerAndroid.java?rcl=0&l=385

BUG=679302
Review-Url: https://codereview.chromium.org/2648173005
Cr-Commit-Position: refs/heads/master@{#446150}
Committed: https://chromium.googlesource.com/chromium/src/+/9047236448cceb86f314cd9ea9d0056f51bccb63

[henrika (OOO until Aug 14), 2017-01-24 15:38:33]

Description was changed from

==========
test

nit

BUG=
==========

to

==========
test

nit

BUG=
==========

[henrika (OOO until Aug 14), 2017-01-24 16:23:28]

Description was changed from

==========
test

nit

BUG=
==========

to

==========

==========

[tommi (sloooow) - chröme, 2017-01-25 09:58:26]

The CQ bit was checked by tommi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 09:58:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 10:04:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 10:04:41]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[henrika (OOO until Aug 14), 2017-01-25 10:08:27]

The CQ bit was checked by henrika@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 10:08:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[henrika (OOO until Aug 14), 2017-01-25 10:08:54]

The CQ bit was unchecked by henrika@chromium.org

[henrika (OOO until Aug 14), 2017-01-25 10:09:18]

The CQ bit was checked by henrika@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 10:09:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 10:16:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 10:16:53]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[tommi (sloooow) - chröme, 2017-01-25 16:21:58]

Description was changed from

==========

==========

to

==========
Add missing permission for webview tests and remove OS specific #ifdef in
getUserMedia code.

The reason for the failures on android turned out to be because of the test
configuration and not the getUserMedia code. The failure we were hitting was in
AndroidAudioManager.java where it turned out that the MODIFY_AUDIO_SETTINGS was
missing from the manifest.

See:
https://cs.chromium.org/chromium/src/media/base/android/java/src/org/chromium...

BUG=679302
==========

[tommi (sloooow) - chröme, 2017-01-25 16:22:35]

lgtm

[tommi (sloooow) - chröme, 2017-01-25 16:23:22]

The CQ bit was checked by tommi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 16:23:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 17:13:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 17:13:54]

Dry run: This issue passed the CQ dry run.

[henrika (OOO until Aug 14), 2017-01-25 17:25:35]

henrika@chromium.org changed reviewers:
+ sgurun@chromium.org

[henrika (OOO until Aug 14), 2017-01-25 17:26:54]

sgurun: adding you for the small change in
android_webview/test/shell/AndroidManifest.xml.

Could you please take a look. Thanks.

[henrika (OOO until Aug 14), 2017-01-25 17:27:10]

The CQ bit was checked by henrika@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 17:27:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 17:31:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 17:31:36]

Dry run: This issue passed the CQ dry run.

[sgurun-gerrit only, 2017-01-25 22:14:11]

On 2017/01/25 17:26:54, henrika wrote:
> sgurun: adding you for the small change in
> android_webview/test/shell/AndroidManifest.xml.
> 
> Could you please take a look. Thanks.

aw lgtm

[tommi (sloooow) - chröme, 2017-01-25 22:25:54]

The CQ bit was checked by tommi@chromium.org

[commit-bot: I haz the power, 2017-01-25 22:27:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 22:57:34]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1485383154496320,
"parent_rev": "d77dd516d0284768f180ec1472a6bd37d0ed8974", "commit_rev":
"9047236448cceb86f314cd9ea9d0056f51bccb63"}

[commit-bot: I haz the power, 2017-01-25 22:58:39]

Description was changed from

==========
Add missing permission for webview tests and remove OS specific #ifdef in
getUserMedia code.

The reason for the failures on android turned out to be because of the test
configuration and not the getUserMedia code. The failure we were hitting was in
AndroidAudioManager.java where it turned out that the MODIFY_AUDIO_SETTINGS was
missing from the manifest.

See:
https://cs.chromium.org/chromium/src/media/base/android/java/src/org/chromium...

BUG=679302
==========

to

==========
Add missing permission for webview tests and remove OS specific #ifdef in
getUserMedia code.

The reason for the failures on android turned out to be because of the test
configuration and not the getUserMedia code. The failure we were hitting was in
AndroidAudioManager.java where it turned out that the MODIFY_AUDIO_SETTINGS was
missing from the manifest.

See:
https://cs.chromium.org/chromium/src/media/base/android/java/src/org/chromium...

BUG=679302

Review-Url: https://codereview.chromium.org/2648173005
Cr-Commit-Position: refs/heads/master@{#446150}
Committed:
https://chromium.googlesource.com/chromium/src/+/9047236448cceb86f314cd9ea9d0...
==========

[commit-bot: I haz the power, 2017-01-25 22:58:40]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/9047236448cceb86f314cd9ea9d0...