Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Unified Diff: content/renderer/media/user_media_client_impl.cc

Issue 2648173005: Add missing permission for webview tests (Closed)
Patch Set: Fixes MediaAccessPermissionRequestTest#testGrantAccess Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/webrtc/webrtc_getusermedia_browsertest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/user_media_client_impl.cc
diff --git a/content/renderer/media/user_media_client_impl.cc b/content/renderer/media/user_media_client_impl.cc
index 533ee29205be55ea4cdf6c854b4dade822ec1585..c490a1c36117ccfaf9168a8893e34afd7b1cad7d 100644
--- a/content/renderer/media/user_media_client_impl.cc
+++ b/content/renderer/media/user_media_client_impl.cc
@@ -1089,14 +1089,6 @@ void UserMediaClientImpl::UserMediaRequestInfo::StartAudioTrack(
OnTrackStarted(
native_source,
connected ? MEDIA_DEVICE_OK : MEDIA_DEVICE_TRACK_START_FAILURE, "");
-#if defined(OS_ANDROID)
- } else if (connected) {
- CHECK(native_source->is_local_source());
- // On Android, we won't get the callback indicating the device readyness.
- // TODO(tommi): Update the android implementation to support the
- // OnAudioSourceStarted notification. http://crbug.com/679302
- OnTrackStarted(native_source, MEDIA_DEVICE_OK, "");
-#endif
}
}
« no previous file with comments | « content/browser/webrtc/webrtc_getusermedia_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698