Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2648163002: Remove case-insensitive matching of usemap attribute. (Closed)

Created:
3 years, 11 months ago by tkent
Modified:
3 years, 11 months ago
Reviewers:
kochi
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, eae+blinkwatch, jam, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 : _ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -198 lines) Patch
M third_party/WebKit/LayoutTests/external/wpt/html/semantics/embedded-content/image-maps/image-map-processing-model/hash-name-reference-expected.txt View 3 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/html/semantics/embedded-content/the-img-element/usemap-casing-expected.txt View 1 chunk +3 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/images/image-map-multiple.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/images/image-map-multiple-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/images/imagemap-case.html View 1 chunk +0 lines, -28 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/images/imagemap-case-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/images/imagemap-case-expected.txt View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/images/imagemap-case-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/images/imagemap-case-expected.txt View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/images/imagemap-case-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/images/imagemap-case-expected.txt View 1 chunk +0 lines, -30 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentOrderedMap.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentOrderedMap.cpp View 2 chunks +0 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/dom/TreeScope.cpp View 3 chunks +2 lines, -43 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMapElement.cpp View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
tkent
kochi@, would you review this please? A trivial feature removal.
3 years, 11 months ago (2017-01-23 05:26:37 UTC) #7
kochi
LGTM Is histograms.xml update unnecessary for removing UseCounters?
3 years, 11 months ago (2017-01-23 06:18:01 UTC) #10
tkent
> Is histograms.xml update unnecessary for removing > UseCounters? I'll update it separately. PRESUBMIT.py doesn't ...
3 years, 11 months ago (2017-01-23 06:41:27 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2648163002/20001
3 years, 11 months ago (2017-01-23 06:41:48 UTC) #13
kochi
On 2017/01/23 06:41:27, tkent wrote: > > Is histograms.xml update unnecessary for removing > > ...
3 years, 11 months ago (2017-01-23 06:43:21 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 06:48:03 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/dcc5978539854826253e97b7c2e4...

Powered by Google App Engine
This is Rietveld 408576698