Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Unified Diff: third_party/WebKit/Source/core/dom/TreeScope.cpp

Issue 2648163002: Remove case-insensitive matching of usemap attribute. (Closed)
Patch Set: _ Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/TreeScope.cpp
diff --git a/third_party/WebKit/Source/core/dom/TreeScope.cpp b/third_party/WebKit/Source/core/dom/TreeScope.cpp
index aad09a602220767557321f7afd69b671e26a09ea..e8e7ac68ecc9406940402174be05dc8e5b61774b 100644
--- a/third_party/WebKit/Source/core/dom/TreeScope.cpp
+++ b/third_party/WebKit/Source/core/dom/TreeScope.cpp
@@ -40,14 +40,11 @@
#include "core/dom/shadow/ShadowRoot.h"
#include "core/editing/DOMSelection.h"
#include "core/events/EventPath.h"
-#include "core/frame/Deprecation.h"
-#include "core/frame/FrameConsole.h"
#include "core/frame/FrameView.h"
#include "core/frame/LocalFrame.h"
#include "core/html/HTMLAnchorElement.h"
#include "core/html/HTMLFrameOwnerElement.h"
#include "core/html/HTMLMapElement.h"
-#include "core/inspector/ConsoleMessage.h"
#include "core/layout/HitTestResult.h"
#include "core/layout/api/LayoutViewItem.h"
#include "core/page/FocusController.h"
@@ -58,21 +55,6 @@ namespace blink {
using namespace HTMLNames;
-namespace {
-
-void addSingletonDeprecationMessageForImageMap(const LocalFrame* frame,
- UseCounter::Feature feature,
- const String& usemap,
- const AtomicString& name) {
- if (!frame)
- return;
- frame->console().addSingletonMessage(ConsoleMessage::create(
- DeprecationMessageSource, WarningMessageLevel,
- Deprecation::deprecationMessage(feature) + " Comparing usemap=" + usemap +
- " and name=" + name));
-}
-}
-
TreeScope::TreeScope(ContainerNode& rootNode, Document& document)
: m_rootNode(&rootNode),
m_document(&document),
@@ -203,31 +185,8 @@ HTMLMapElement* TreeScope::getImageMap(const String& url) const {
return nullptr;
size_t hashPos = url.find('#');
String name = hashPos == kNotFound ? url : url.substring(hashPos + 1);
- HTMLMapElement* map = toHTMLMapElement(
- document().isHTMLDocument()
- ? m_imageMapsByName->getElementByLowercasedMapName(
- AtomicString(name.lower()), this)
- : m_imageMapsByName->getElementByMapName(AtomicString(name), this));
- if (!map || !document().isHTMLDocument())
- return map;
- const AtomicString& nameValue = map->fastGetAttribute(nameAttr);
- if (nameValue.isNull())
- return map;
- String strippedName = nameValue;
- if (strippedName.startsWith('#'))
- strippedName = strippedName.substring(1);
- if (strippedName == name) {
- UseCounter::count(document(), UseCounter::MapNameMatchingStrict);
- } else if (equalIgnoringASCIICase(strippedName, name)) {
- addSingletonDeprecationMessageForImageMap(
- document().frame(), UseCounter::MapNameMatchingASCIICaseless, url,
- nameValue);
- } else {
- addSingletonDeprecationMessageForImageMap(
- document().frame(), UseCounter::MapNameMatchingUnicodeLower, url,
- nameValue);
- }
- return map;
+ return toHTMLMapElement(
+ m_imageMapsByName->getElementByMapName(AtomicString(name), this));
}
static bool pointWithScrollAndZoomIfPossible(const Document& document,
« no previous file with comments | « third_party/WebKit/Source/core/dom/DocumentOrderedMap.cpp ('k') | third_party/WebKit/Source/core/frame/Deprecation.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698