Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 2648063002: Remove unneeded #defines from libjingle_xmpp. (Closed)

Created:
3 years, 11 months ago by Taylor_Brandstetter
Modified:
3 years, 11 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unneeded #defines from libjingle_xmpp. Specifically, "FEATURE_ENABLE_SSL" and "FEATURE_ENABLE_VOICEMAIL". Compilation without these defines no longer works or is tested, so removing them should reduce some confusion. BUG=webrtc:7025 Review-Url: https://codereview.chromium.org/2648063002 Cr-Commit-Position: refs/heads/master@{#445351} Committed: https://chromium.googlesource.com/chromium/src/+/ca8d9df017fed0f96f565f0c61f6917f56814278

Patch Set 1 #

Patch Set 2 : Restoring unintentionally deleted copyright line #

Total comments: 2

Patch Set 3 : Also remove "FEATURE_ENABLE_VOICEMAIL" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -26 lines) Patch
M jingle/glue/chrome_async_socket.h View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/libjingle_xmpp/BUILD.gn View 1 2 3 chunks +1 line, -10 lines 0 comments Download
M third_party/libjingle_xmpp/xmpp/asyncsocket.h View 3 chunks +0 lines, -6 lines 0 comments Download
M third_party/libjingle_xmpp/xmpp/constants.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/libjingle_xmpp/xmpp/constants.cc View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/libjingle_xmpp/xmpp/xmppclient.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Taylor_Brandstetter
PTAL
3 years, 11 months ago (2017-01-21 02:21:15 UTC) #2
Sergey Ulanov
https://codereview.chromium.org/2648063002/diff/20001/third_party/libjingle_xmpp/BUILD.gn File third_party/libjingle_xmpp/BUILD.gn (right): https://codereview.chromium.org/2648063002/diff/20001/third_party/libjingle_xmpp/BUILD.gn#newcode52 third_party/libjingle_xmpp/BUILD.gn:52: "FEATURE_ENABLE_VOICEMAIL", this one can be removed as well
3 years, 11 months ago (2017-01-21 04:18:13 UTC) #3
Taylor_Brandstetter
https://codereview.chromium.org/2648063002/diff/20001/third_party/libjingle_xmpp/BUILD.gn File third_party/libjingle_xmpp/BUILD.gn (right): https://codereview.chromium.org/2648063002/diff/20001/third_party/libjingle_xmpp/BUILD.gn#newcode52 third_party/libjingle_xmpp/BUILD.gn:52: "FEATURE_ENABLE_VOICEMAIL", On 2017/01/21 04:18:13, Sergey Ulanov wrote: > this ...
3 years, 11 months ago (2017-01-21 04:26:29 UTC) #5
Sergey Ulanov
lgtm
3 years, 11 months ago (2017-01-23 08:56:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2648063002/40001
3 years, 11 months ago (2017-01-23 08:56:51 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 11:06:00 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ca8d9df017fed0f96f565f0c61f6...

Powered by Google App Engine
This is Rietveld 408576698