Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Side by Side Diff: third_party/libjingle_xmpp/BUILD.gn

Issue 2648063002: Remove unneeded #defines from libjingle_xmpp. (Closed)
Patch Set: Restoring unintentionally deleted copyright line Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « jingle/glue/chrome_async_socket.h ('k') | third_party/libjingle_xmpp/xmpp/asyncsocket.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # TODO(kjellander): Remove remaining dependencies on the WebRTC codebase. 5 # TODO(kjellander): Remove remaining dependencies on the WebRTC codebase.
6 import("../webrtc/build/webrtc.gni") 6 import("../webrtc/build/webrtc.gni")
7 7
8 group("libjingle_xmpp") { 8 group("libjingle_xmpp") {
9 public_deps = [ 9 public_deps = [
10 ":rtc_xmllite", 10 ":rtc_xmllite",
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 # GN orders flags on a target before flags from configs. The default config 42 # GN orders flags on a target before flags from configs. The default config
43 # adds these flags so to cancel them out they need to come from a config and 43 # adds these flags so to cancel them out they need to come from a config and
44 # cannot be on the target directly. 44 # cannot be on the target directly.
45 if (is_android) { 45 if (is_android) {
46 cflags = [ "-Wno-error" ] 46 cflags = [ "-Wno-error" ]
47 } 47 }
48 } 48 }
49 49
50 config("rtc_xmpp_inherited_config") { 50 config("rtc_xmpp_inherited_config") {
51 defines = [ 51 defines = [
52 "FEATURE_ENABLE_SSL",
53 "FEATURE_ENABLE_VOICEMAIL", 52 "FEATURE_ENABLE_VOICEMAIL",
Sergey Ulanov 2017/01/21 04:18:13 this one can be removed as well
Taylor_Brandstetter 2017/01/21 04:26:29 Done.
54 ] 53 ]
55 } 54 }
56 55
57 rtc_static_library("rtc_xmpp") { 56 rtc_static_library("rtc_xmpp") {
58 cflags = [] 57 cflags = []
59 sources = [ 58 sources = [
60 "xmpp/asyncsocket.h", 59 "xmpp/asyncsocket.h",
61 "xmpp/constants.cc", 60 "xmpp/constants.cc",
62 "xmpp/constants.h", 61 "xmpp/constants.h",
63 "xmpp/jid.cc", 62 "xmpp/jid.cc",
(...skipping 13 matching lines...) Expand all
77 "xmpp/xmppengineimpl.h", 76 "xmpp/xmppengineimpl.h",
78 "xmpp/xmppengineimpl_iq.cc", 77 "xmpp/xmppengineimpl_iq.cc",
79 "xmpp/xmpplogintask.cc", 78 "xmpp/xmpplogintask.cc",
80 "xmpp/xmpplogintask.h", 79 "xmpp/xmpplogintask.h",
81 "xmpp/xmppstanzaparser.cc", 80 "xmpp/xmppstanzaparser.cc",
82 "xmpp/xmppstanzaparser.h", 81 "xmpp/xmppstanzaparser.h",
83 "xmpp/xmpptask.cc", 82 "xmpp/xmpptask.cc",
84 "xmpp/xmpptask.h", 83 "xmpp/xmpptask.h",
85 ] 84 ]
86 85
87 defines = [ "FEATURE_ENABLE_SSL" ] 86 defines = []
88 87
89 deps = [ 88 deps = [
90 ":rtc_xmllite", 89 ":rtc_xmllite",
91 "//third_party/webrtc/base:rtc_base", 90 "//third_party/webrtc/base:rtc_base",
92 ] 91 ]
93 public_deps = [ 92 public_deps = [
94 "//third_party/expat", 93 "//third_party/expat",
95 ] 94 ]
96 configs += [ ":rtc_xmpp_warnings_config" ] 95 configs += [ ":rtc_xmpp_warnings_config" ]
97 96
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
144 "xmllite/xmlprinter_unittest.cc", 143 "xmllite/xmlprinter_unittest.cc",
145 "xmpp/fakexmppclient.h", 144 "xmpp/fakexmppclient.h",
146 "xmpp/jid_unittest.cc", 145 "xmpp/jid_unittest.cc",
147 "xmpp/util_unittest.cc", 146 "xmpp/util_unittest.cc",
148 "xmpp/util_unittest.h", 147 "xmpp/util_unittest.h",
149 "xmpp/xmppengine_unittest.cc", 148 "xmpp/xmppengine_unittest.cc",
150 "xmpp/xmpplogintask_unittest.cc", 149 "xmpp/xmpplogintask_unittest.cc",
151 "xmpp/xmppstanzaparser_unittest.cc", 150 "xmpp/xmppstanzaparser_unittest.cc",
152 ] 151 ]
153 } 152 }
OLDNEW
« no previous file with comments | « jingle/glue/chrome_async_socket.h ('k') | third_party/libjingle_xmpp/xmpp/asyncsocket.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698