Switch Shadow DOM V0 <content> FeatureSet tests to SimTest.

Switch Shadow DOM V0 <content> FeatureSet tests to SimTest.

This lets us remove three methods from internals. Once we have this new SimTest
we can also port lots of other tests and remove more internals methods specific
to testing shadow dom.

BUG=682982
Review-Url: https://codereview.chromium.org/2647843002
Cr-Commit-Position: refs/heads/master@{#459018}
Committed: https://chromium.googlesource.com/chromium/src/+/415f9bab260d050f3471daae4282a267aa954094

[esprehn, 2017-01-20 04:21:40]

Description was changed from

==========
Switch Shadow DOM V0 FeatureSet tests to Si SimTest.

This lets us remove three methods from internals.

BUG=682982
==========

to

==========
Switch Shadow DOM V0 FeatureSet tests to SimTest.

This lets us remove three methods from internals.

BUG=682982
==========

[esprehn, 2017-01-20 04:21:59]

Description was changed from

==========
Switch Shadow DOM V0 FeatureSet tests to SimTest.

This lets us remove three methods from internals.

BUG=682982
==========

to

==========
Switch Shadow DOM V0 <content> FeatureSet tests to SimTest.

This lets us remove three methods from internals.

BUG=682982
==========

[esprehn, 2017-01-20 04:23:16]

The CQ bit was checked by esprehn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 04:23:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[esprehn, 2017-01-20 04:57:28]

Description was changed from

==========
Switch Shadow DOM V0 <content> FeatureSet tests to SimTest.

This lets us remove three methods from internals.

BUG=682982
==========

to

==========
Switch Shadow DOM V0 <content> FeatureSet tests to SimTest.

This lets us remove three methods from internals. Once we have this new SimTest
we can also port lots of other tests and remove more internals methods specific
to testing shadow dom.

BUG=682982
==========

[esprehn, 2017-01-20 05:10:59]

esprehn@chromium.org changed reviewers:
+ dglazkov@chromium.org

[commit-bot: I haz the power, 2017-01-20 05:19:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 05:19:43]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[rune, 2017-01-20 11:41:16]

rune@opera.com changed reviewers:
+ rune@opera.com

[rune, 2017-01-20 11:41:16]

https://codereview.chromium.org/2647843002/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/web/tests/ShadowDOMV0Test.cpp (right):

https://codereview.chromium.org/2647843002/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/tests/ShadowDOMV0Test.cpp:9: #include
"web/tests/sim/SimRequest.h"
Are all of these includes needed? SimDisplayItemList.h looks unused, at least.

https://codereview.chromium.org/2647843002/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/tests/ShadowDOMV0Test.cpp:17: DCHECK(host);
Don't we typically use ASSERT_TRUE instead of DCHECK in tests?

All tests below access host-> before calling these methods, though.

https://codereview.chromium.org/2647843002/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/tests/ShadowDOMV0Test.cpp:34: class ShadowDOMVTest
: public SimTest {};
ShadowDOMVTest -> ShadowDOMV0Test ?

[dglazkov, 2017-02-03 22:26:37]

LGTM % rune's comments

[esprehn, 2017-02-03 22:31:10]

https://codereview.chromium.org/2647843002/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/web/tests/ShadowDOMV0Test.cpp (right):

https://codereview.chromium.org/2647843002/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/tests/ShadowDOMV0Test.cpp:9: #include
"web/tests/sim/SimRequest.h"
On 2017/01/20 at 11:41:16, rune wrote:
> Are all of these includes needed? SimDisplayItemList.h looks unused, at least.

BeginFrame() returns an instance of it and it's forward declared. I should
probably fix that to not forward declare it since it's annoying to include it in
every test

https://codereview.chromium.org/2647843002/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/tests/ShadowDOMV0Test.cpp:17: DCHECK(host);
On 2017/01/20 at 11:41:16, rune wrote:
> Don't we typically use ASSERT_TRUE instead of DCHECK in tests?
> 
> All tests below access host-> before calling these methods, though.

This was a support method so an assert looked funny.

https://codereview.chromium.org/2647843002/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/tests/ShadowDOMV0Test.cpp:34: class ShadowDOMVTest
: public SimTest {};
On 2017/01/20 at 11:41:16, rune wrote:
> ShadowDOMVTest -> ShadowDOMV0Test ?

Woops yeah

[rune, 2017-02-06 11:53:46]

https://codereview.chromium.org/2647843002/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/web/tests/ShadowDOMV0Test.cpp (right):

https://codereview.chromium.org/2647843002/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/tests/ShadowDOMV0Test.cpp:17: DCHECK(host);
On 2017/02/03 22:31:10, esprehn wrote:
> On 2017/01/20 at 11:41:16, rune wrote:
> > Don't we typically use ASSERT_TRUE instead of DCHECK in tests?
> > 
> > All tests below access host-> before calling these methods, though.
> 
> This was a support method so an assert looked funny.

Acknowledged.

[esprehn, 2017-03-23 02:56:08]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2017-03-23 02:56:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 03:12:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 03:12:28]

Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[esprehn, 2017-03-23 06:34:40]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2017-03-23 06:34:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 06:58:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 06:58:02]

Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[esprehn, 2017-03-23 07:34:53]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2017-03-23 07:35:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 07:53:09]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490254493883130, "parent_rev":
"dee8e0a41990efbaec2435faff764baee5b894d9", "commit_rev":
"415f9bab260d050f3471daae4282a267aa954094"}

[commit-bot: I haz the power, 2017-03-23 07:54:13]

Description was changed from

==========
Switch Shadow DOM V0 <content> FeatureSet tests to SimTest.

This lets us remove three methods from internals. Once we have this new SimTest
we can also port lots of other tests and remove more internals methods specific
to testing shadow dom.

BUG=682982
==========

to

==========
Switch Shadow DOM V0 <content> FeatureSet tests to SimTest.

This lets us remove three methods from internals. Once we have this new SimTest
we can also port lots of other tests and remove more internals methods specific
to testing shadow dom.

BUG=682982

Review-Url: https://codereview.chromium.org/2647843002
Cr-Commit-Position: refs/heads/master@{#459018}
Committed:
https://chromium.googlesource.com/chromium/src/+/415f9bab260d050f3471daae4282...
==========

[commit-bot: I haz the power, 2017-03-23 07:54:15]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/415f9bab260d050f3471daae4282...