Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: third_party/WebKit/Source/core/dom/Element.h

Issue 2647843002: Switch Shadow DOM V0 <content> FeatureSet tests to SimTest. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/Element.h
diff --git a/third_party/WebKit/Source/core/dom/Element.h b/third_party/WebKit/Source/core/dom/Element.h
index b1d8247167de927328c63ad63f1763a4f38fb5f0..607d031d9c702aa6b7e6960dbf6593bcd400ffc8 100644
--- a/third_party/WebKit/Source/core/dom/Element.h
+++ b/third_party/WebKit/Source/core/dom/Element.h
@@ -184,7 +184,7 @@ class CORE_EXPORT Element : public ContainerNode {
void setAttribute(const AtomicString& name,
const AtomicString& value,
- ExceptionState&);
+ ExceptionState& = ASSERT_NO_EXCEPTION);
static bool parseAttributeName(QualifiedName&,
const AtomicString& namespaceURI,
const AtomicString& qualifiedName,
@@ -433,7 +433,12 @@ class CORE_EXPORT Element : public ContainerNode {
// creation of multiple shadow roots is prohibited in any combination and
// throws an exception. Multiple shadow roots are allowed only when
// createShadowRoot() is used without any parameters from JavaScript.
- ShadowRoot* createShadowRoot(const ScriptState*, ExceptionState&);
+ //
+ // TODO(esprehn): These take a ScriptState only for calling
+ // HostsUsingFeatures::countMainWorldOnly, which should be handled in the
+ // bindings instead so adding a ShadowRoot from C++ doesn't need one.
+ ShadowRoot* createShadowRoot(const ScriptState* = nullptr,
+ ExceptionState& = ASSERT_NO_EXCEPTION);
ShadowRoot* attachShadow(const ScriptState*,
const ShadowRootInit&,
ExceptionState&);

Powered by Google App Engine
This is Rietveld 408576698