Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 2647833004: [turbofan] Properly implement %_ClassOf intrinsic. (Closed)

Created:
3 years, 11 months ago by Benedikt Meurer
Modified:
3 years, 11 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Properly implement %_ClassOf intrinsic. The %_ClassOf intrinsic roughly corresponds to the deprecated ES5 [[Class]] internal property, and should not be used anymore ideally. However since we still have quite a couple of uses of this intrinsic in the self hosted JavaScript builtins, we would tank some builtins like Map, Set, WeakMap, WeakSet, etc. quite significantly unless we also support this intrinsic until the builtins are all migrated to C++/CSA builtins. R=yangguo@chromium.org BUG=v8:5267 Review-Url: https://codereview.chromium.org/2647833004 Cr-Commit-Position: refs/heads/master@{#42530} Committed: https://chromium.googlesource.com/v8/v8/+/3e4070930dddff8e53067141d60add6f5a15b44a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -60 lines) Patch
M src/builtins/builtins.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/builtins/builtins-conversion.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/code-factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/code-factory.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/code-stub-assembler.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/code-stub-assembler.cc View 1 chunk +51 lines, -0 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M src/compiler/js-operator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-operator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/linkage.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/typer.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/compiler/types.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M src/interpreter/interpreter-intrinsics.cc View 1 chunk +2 lines, -56 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (6 generated)
Benedikt Meurer
3 years, 11 months ago (2017-01-20 06:27:23 UTC) #1
Yang
On 2017/01/20 06:27:23, Benedikt Meurer wrote: lgtm. but so sad that we are introducing throw-away ...
3 years, 11 months ago (2017-01-20 06:34:19 UTC) #4
Benedikt Meurer
On 2017/01/20 06:34:19, Yang wrote: > On 2017/01/20 06:27:23, Benedikt Meurer wrote: > > lgtm. ...
3 years, 11 months ago (2017-01-20 06:38:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2647833004/1
3 years, 11 months ago (2017-01-20 06:38:53 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 07:01:59 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/3e4070930dddff8e53067141d60add6f5a1...

Powered by Google App Engine
This is Rietveld 408576698