Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 2642303003: [ignition] Remove obsolete %_ValueOf intrinsic. (Closed)

Created:
3 years, 11 months ago by Benedikt Meurer
Modified:
3 years, 11 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ignition] Remove obsolete %_ValueOf intrinsic. The %_ValueOf intrinsic is not used anymore and the runtime call %ValueOf will also disappear once all the self hosted builtins are migrated. R=rmcilroy@chromium.org Review-Url: https://codereview.chromium.org/2642303003 Cr-Commit-Position: refs/heads/master@{#42544} Committed: https://chromium.googlesource.com/v8/v8/+/0ff07a5bfb26af1684816c522b6e5b2970fdbbbf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -48 lines) Patch
M src/interpreter/interpreter-intrinsics.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/interpreter/interpreter-intrinsics.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M test/cctest/interpreter/test-interpreter-intrinsics.cc View 1 chunk +0 lines, -21 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (7 generated)
Benedikt Meurer
3 years, 11 months ago (2017-01-20 06:55:53 UTC) #1
Benedikt Meurer
Hey Ross, Here's a trivial cleanup for Ignition. Please take a look. Thanks, Benedikt
3 years, 11 months ago (2017-01-20 06:56:53 UTC) #4
rmcilroy
LGTM, thanks.
3 years, 11 months ago (2017-01-20 09:27:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2642303003/1
3 years, 11 months ago (2017-01-20 10:13:57 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 10:45:43 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/0ff07a5bfb26af1684816c522b6e5b2970f...

Powered by Google App Engine
This is Rietveld 408576698