Use entities in some full_emitter sublibraries

Use entities in some full_emitter sublibraries

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/bb9baa6822b03e2e036bd1777bcfc6fd6d01557d

[Johnni Winther, 2017-01-20 15:19:18]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-01-20 17:10:01]

lgtm

https://codereview.chromium.org/2647793003/diff/1/pkg/compiler/lib/src/js_emi...
File pkg/compiler/lib/src/js_emitter/full_emitter/nsm_emitter.dart (right):

https://codereview.chromium.org/2647793003/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/full_emitter/nsm_emitter.dart:75:
.any(backend.isMemberAccessibleByReflection);
am I understanding correctly that the extra check in isAccessibleByReflection
couldn't match here? (since these are just functions so you'd never have one of
the native JS* classes here)?

[Johnni Winther, 2017-01-23 10:20:07]

https://codereview.chromium.org/2647793003/diff/1/pkg/compiler/lib/src/js_emi...
File pkg/compiler/lib/src/js_emitter/full_emitter/nsm_emitter.dart (right):

https://codereview.chromium.org/2647793003/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/full_emitter/nsm_emitter.dart:75:
.any(backend.isMemberAccessibleByReflection);
On 2017/01/20 17:10:01, Siggi Cherem (dart-lang) wrote:
> am I understanding correctly that the extra check in isAccessibleByReflection
> couldn't match here? (since these are just functions so you'd never have one
of
> the native JS* classes here)?

Yes. This was provoked by the type mismatch, but in general I want to split
these kinds of methods into class and member related versions; they tend have
different semantics and keeping classes and members apart also gives much
cleaner implementations.

[Johnni Winther, 2017-01-23 10:26:34]

Description was changed from

==========
Use entities in some full_emitter sublibraries
==========

to

==========
Use entities in some full_emitter sublibraries

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/bb9baa6822b03e2e036bd1777bcfc6fd6d01557d
==========

[Johnni Winther, 2017-01-23 10:26:35]

Committed patchset #1 (id:1) manually as
bb9baa6822b03e2e036bd1777bcfc6fd6d01557d (presubmit successful).