Use entities in some full_emitter sublibraries

pkg/compiler/lib/src/js_emitter/full_emitter/nsm_emitter.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart2js.js_emitter.full_emitter.nsm_emitter;
 
-import '../../elements/elements.dart'
-    show
-    ClassElement,
-    MemberElement;
+import '../../elements/entities.dart';
 import '../../js/js.dart' as jsAst;
 import '../../js/js.dart' show js;
-import '../../js_backend/js_backend.dart'
-    show
-    GetterName,
-    SetterName;
+import '../../js_backend/js_backend.dart' show GetterName, SetterName;
 import '../../universe/selector.dart' show Selector;
 import '../../util/characters.dart' show $$, $A, $HASH, $Z, $a, $z;
 import '../../world.dart' show ClosedWorld;
 import '../js_emitter.dart' hide Emitter, EmitterFactory;
 import '../model.dart';
 import 'emitter.dart';
 
 class NsmEmitter extends CodeEmitterHelper {
   final ClosedWorld closedWorld;
   final List<Selector> trivialNsmHandlers = <Selector>[];
@@ skipping 44 matching lines @@
           isTrivialNsmHandler(type, argNames, selector, jsName) &&
           reflectionName == null) {
         trivialNsmHandlers.add(selector);
       } else {
         StubMethod method =
             generator.generateStubForNoSuchMethod(jsName, selector);
         addProperty(method.name, method.code);
         if (reflectionName != null) {
           bool accessible = closedWorld.allFunctions
               .filter(selector, null)
-              .any((MemberElement e) => backend.isAccessibleByReflection(e));
+              .any(backend.isMemberAccessibleByReflection);

[Siggi Cherem (dart-lang), 2017/01/20 17:10:01]

am I understanding correctly that the extra check in isAccessibleByReflection
couldn't match here? (since these are just functions so you'd never have one of
the native JS* classes here)?

[Johnni Winther, 2017/01/23 10:20:06]

Yes. This was provoked by the type mismatch, but in general I want to split
these kinds of methods into class and member related versions; they tend have
different semantics and keeping classes and members apart also gives much
cleaner implementations.

           addProperty(
               namer.asName('+$reflectionName'), js(accessible ? '2' : '0'));
         }
       }
     }
   }
 
   // Identify the noSuchMethod handlers that are so simple that we can
   // generate them programatically.
   bool isTrivialNsmHandler(
@@ skipping 80 matching lines @@
               js.stringPart(",")),
           addQuotes: true);
 
       if (!minify) {
         sortedLongs =
             sorted.map((selector) => selector.invocationMirrorMemberName);
       }
     }
     // Startup code that loops over the method names and puts handlers on the
     // Object class to catch noSuchMethod invocations.
-    ClassElement objectClass = compiler.commonElements.objectClass;
+    ClassEntity objectClass = compiler.commonElements.objectClass;
     jsAst.Expression createInvocationMirror = backend.emitter
         .staticFunctionAccess(backend.helpers.createInvocationMirror);
     if (useDiffEncoding) {
       statements.add(js.statement(
           '''{
           var objectClassObject = processedClasses.collected[#objectClass],
               nameSequences = #diffEncoding.split("."),
               shortNames = [];
           if (objectClassObject instanceof Array)
               objectClassObject = objectClassObject[1];
@@ skipping 215 matching lines @@
   }
 
   String get value {
     if (_cachedValue == null) {
       _cachedValue = _computeDiffEncoding();
     }
 
     return _cachedValue;
   }
 }