Use entities in some full_emitter sublibraries

pkg/compiler/lib/src/js_emitter/full_emitter/nsm_emitter.dart

Index: pkg/compiler/lib/src/js_emitter/full_emitter/nsm_emitter.dart
diff --git a/pkg/compiler/lib/src/js_emitter/full_emitter/nsm_emitter.dart b/pkg/compiler/lib/src/js_emitter/full_emitter/nsm_emitter.dart
index c489cb579ee3d14f06e4c4b76ad78e40e2ba3341..472a2c7c5cd71eef45f61ae6578595aa03e8534a 100644
--- a/pkg/compiler/lib/src/js_emitter/full_emitter/nsm_emitter.dart
+++ b/pkg/compiler/lib/src/js_emitter/full_emitter/nsm_emitter.dart
@@ -4,16 +4,10 @@
 
 library dart2js.js_emitter.full_emitter.nsm_emitter;
 
-import '../../elements/elements.dart'
-    show
-    ClassElement,
-    MemberElement;
+import '../../elements/entities.dart';
 import '../../js/js.dart' as jsAst;
 import '../../js/js.dart' show js;
-import '../../js_backend/js_backend.dart'
-    show
-    GetterName,
-    SetterName;
+import '../../js_backend/js_backend.dart' show GetterName, SetterName;
 import '../../universe/selector.dart' show Selector;
 import '../../util/characters.dart' show $$, $A, $HASH, $Z, $a, $z;
 import '../../world.dart' show ClosedWorld;
@@ -78,7 +72,7 @@ class NsmEmitter extends CodeEmitterHelper {
         if (reflectionName != null) {
           bool accessible = closedWorld.allFunctions
               .filter(selector, null)
-              .any((MemberElement e) => backend.isAccessibleByReflection(e));
+              .any(backend.isMemberAccessibleByReflection);

[Siggi Cherem (dart-lang), 2017/01/20 17:10:01]

am I understanding correctly that the extra check in isAccessibleByReflection
couldn't match here? (since these are just functions so you'd never have one of
the native JS* classes here)?

[Johnni Winther, 2017/01/23 10:20:06]

Yes. This was provoked by the type mismatch, but in general I want to split
these kinds of methods into class and member related versions; they tend have
different semantics and keeping classes and members apart also gives much
cleaner implementations.

           addProperty(
               namer.asName('+$reflectionName'), js(accessible ? '2' : '0'));
         }
@@ -179,7 +173,7 @@ class NsmEmitter extends CodeEmitterHelper {
     }
     // Startup code that loops over the method names and puts handlers on the
     // Object class to catch noSuchMethod invocations.
-    ClassElement objectClass = compiler.commonElements.objectClass;
+    ClassEntity objectClass = compiler.commonElements.objectClass;
     jsAst.Expression createInvocationMirror = backend.emitter
         .staticFunctionAccess(backend.helpers.createInvocationMirror);
     if (useDiffEncoding) {