Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2647733002: [turbofan] Recognize a couple of collection.js intrinsics. (Closed)

Created:
3 years, 11 months ago by Benedikt Meurer
Modified:
3 years, 11 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Recognize a couple of collection.js intrinsics. Right now running the Map and Set builtins with I+TF would tank seriously because these builtins are still built on top of a couple of classic intrinsics that TurboFan doesn't understand. Middle-term the idea is to replace the Map and Set builtins with a CodeStubAssembler based solution, but for that might not be ready in time, so adding support for a couple of the critical intrinsics to mitigate the tankage a bit, namely - %_JSCollectionGetTable, - %_TheHole, and - %_StringGetRawHashField. Together these double the score on most of the existing performance tests for collections. R=yangguo@chromium.org BUG=v8:5267 Review-Url: https://codereview.chromium.org/2647733002 Cr-Commit-Position: refs/heads/master@{#42521} Committed: https://chromium.googlesource.com/v8/v8/+/d389e49b5c0f3b41a97782257dfd91fb8a5d6551

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -3 lines) Patch
M src/compiler/access-builder.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/access-builder.cc View 2 chunks +12 lines, -3 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 3 chunks +32 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (6 generated)
Benedikt Meurer
3 years, 11 months ago (2017-01-19 20:30:14 UTC) #1
Yang
On 2017/01/19 20:30:14, Benedikt Meurer wrote: lgtm
3 years, 11 months ago (2017-01-19 20:45:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2647733002/1
3 years, 11 months ago (2017-01-19 20:45:59 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 21:03:13 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/d389e49b5c0f3b41a97782257dfd91fb8a5...

Powered by Google App Engine
This is Rietveld 408576698