Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2646523004: [turbofan] Assign proper type to %ClassOf/%_ClassOf. (Closed)

Created:
3 years, 11 months ago by Benedikt Meurer
Modified:
3 years, 11 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Assign proper type to %ClassOf/%_ClassOf. The %ClassOf runtime function and %_ClassOf intrinsics always produce an internalized string, or Null for primitive inputs. BUG=v8:5267 R=yangguo@chromium.org Review-Url: https://codereview.chromium.org/2646523004 Cr-Commit-Position: refs/heads/master@{#42522} Committed: https://chromium.googlesource.com/v8/v8/+/4e565c68ff0a0fa029852131a324805ec225dcf8

Patch Set 1 #

Patch Set 2 : REBASE. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/compiler/typer.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Benedikt Meurer
3 years, 11 months ago (2017-01-19 20:36:22 UTC) #1
Yang
On 2017/01/19 20:36:22, Benedikt Meurer wrote: lgtm
3 years, 11 months ago (2017-01-19 20:42:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2646523004/20001
3 years, 11 months ago (2017-01-19 20:45:48 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 21:16:33 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/4e565c68ff0a0fa029852131a324805ec22...

Powered by Google App Engine
This is Rietveld 408576698